Fixing bugs in Sankey diagrams (apache#2290)

* NULL values for name breaks the chart * negative rect svg height values
vera-liu · Feb 28, 2017 · 47be3ef · 47be3ef
1 parent 9dd7778
commit 47be3ef
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/superset/assets/visualizations/sankey.js b/superset/assets/visualizations/sankey.js
@@ -132,14 +132,13 @@ function sankeyVis(slice, payload) {
       })
       .on('drag', dragmove)
     );
-
+  const minRectHeight = 5;
   node.append('rect')
-    .attr('height', function (d) {
-      return d.dy;
-    })
+    .attr('height', d => d.dy > minRectHeight ? d.dy : minRectHeight)
     .attr('width', sankey.nodeWidth())
     .style('fill', function (d) {
-      d.color = category21(d.name.replace(/ .*/, ''));
+      const name = d.name || 'N/A';
+      d.color = category21(name.replace(/ .*/, ''));
       return d.color;
     })
     .style('stroke', function (d) {