Support /dev/disk/by-id/
symlinks in command-line installer
#1422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the command-line installer fails when giving the target device as a
/dev/disk/by-id
symlink (since it tries to access more information about the device in the/sys/
filesystem, for example/sys/class/block/${DISK#/dev/}/start
). Many Linux users (including myself) prefer using these/dev/disk/by-id
symlinks instead of raw device names (especially for dangerous operations such as formatting a device) since this reduces the probability of accidentally using an incorrect device.This PR will resolve the symlink in the beginning of
VentoyWorker.sh
(directly when parsing the command-line arguments).