Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(admin-ui): Add translation ru #829

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

XeL077
Copy link
Contributor

@XeL077 XeL077 commented Apr 18, 2021

translate ru

Copy link
Contributor

@Izayda Izayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I have wrote some comments for pieces of translation that noticed.

"asset": {
"add-asset": "Добавить медиа-объект",
"add-asset-with-count": "Добавить {count, plural, 0 {assets} one {1 asset} other {{count} assets}}",
"assets-selected-count": "{ count } выбранные активы",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выбрано объектов

"add-asset": "Добавить медиа-объект",
"add-asset-with-count": "Добавить {count, plural, 0 {assets} one {1 asset} other {{count} assets}}",
"assets-selected-count": "{ count } выбранные активы",
"dimensions": "Габаритные размеры",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Размеры (без слова габаритные)

"create-new-administrator": "Создать нового администратора"
},
"asset": {
"add-asset": "Добавить медиа-объект",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если использовать фразу "медиа-объект", то лучше его использовать во всех фразах перевода этого блока

"add-asset-with-count": "Добавить {count, plural, 0 {assets} one {1 asset} other {{count} assets}}",
"assets-selected-count": "{ count } выбранные активы",
"dimensions": "Габаритные размеры",
"focal-point": "Координаты",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точка фокуса

"assets-selected-count": "{ count } выбранные активы",
"dimensions": "Габаритные размеры",
"focal-point": "Координаты",
"notify-create-assets-success": "Created {count, plural, one {new Asset} other {{count} new Assets}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут перевод почему-то отсутсвует

"password": "Пароль",
"phone-number": "Телефонный номер",
"postal-code": "Почтовый индекс",
"province": "Провинция",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Регион

"select-customer": "Выберите клиента",
"set-as-default-billing-address": "Установить в качестве биллинга по умолчанию",
"set-as-default-shipping-address": "Установить как доставку по умолчанию",
"street-line-1": "Уличная линия 1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Улица, строка 1

"set-as-default-billing-address": "Установить в качестве биллинга по умолчанию",
"set-as-default-shipping-address": "Установить как доставку по умолчанию",
"street-line-1": "Уличная линия 1",
"street-line-2": "Уличная линия 2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Улица, строка 2

"countries": "Страны",
"customer-groups": "Группы клиентов",
"customers": "Клиенты",
"facets": "Facets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Срезы

"cancelled-order-success": "Успешно отмененный заказ",
"confirm-modifications": "Подтвердите изменения",
"contents": "Содержимое",
"create-fulfillment": "Создавайте удовлетворение",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удолетворение?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Создать выполнение?"
Какой тут контекст использования?

@michaelbromley michaelbromley merged commit 650f38e into vendure-ecommerce:master Apr 19, 2021
michaelbromley added a commit that referenced this pull request Apr 19, 2021
@michaelbromley
Copy link
Member

@Izayda I pushed the "merge" button just as your comments popped up in the GitHub UI!

If there are any refinements to be made, I'll accept another PR. I have no judgement on this so I'll let the experts decide what is correct!

@Izayda
Copy link
Contributor

Izayda commented Apr 19, 2021

Yeah, we made it at the same time) @XeL077 can we together improve some moments of translation? I have wrote some comments while morning coffee

@XeL077
Copy link
Contributor Author

XeL077 commented Apr 19, 2021

@Izayda, yes! I will improve translate and create new pull request.
Some lines I could not think of how to translate correctly.

I will run this version of the translation and do the validation using the context of use.

@XeL077
Copy link
Contributor Author

XeL077 commented Apr 19, 2021

@michaelbromley, will this translation already be available in the current master build version?

@Izayda
Copy link
Contributor

Izayda commented Apr 19, 2021

Thank you! You can write me before before creating PR and i can review your fork branch and if there will be some marks, i can made a PR to your fork to help you.

@michaelbromley
Copy link
Member

@XeL077 yes, the original PR you made has been merged into the master branch. Once you an Artem have made the necessary improvements I'll then merge the updated PR too. I plan to make a beta release in the next day or so, and these translations will be included in that release.

@XeL077 XeL077 deleted the add-ru-translate branch April 19, 2021 22:34
@XeL077
Copy link
Contributor Author

XeL077 commented Apr 20, 2021

@Izayda, hi! My fixes are here in the branch ->
XeL077@1cf9d43

Am I create pull request?
Maybe I forget some i18n messages lang keys. I will try to find and add them.

@Izayda
Copy link
Contributor

Izayda commented Apr 21, 2021

Hi! Great, thanks! I will look your branch today until evening

@Izayda
Copy link
Contributor

Izayda commented Apr 22, 2021

@XeL077 great job, really! Yeah, let's create PR. There are some small unimportant remarks, i will fix them in another PR next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants