-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customize Admin UI branding options #610
Allow customize Admin UI branding options #610
Conversation
Hi! Wow thanks for all your work on this PR! I'm just catching up on a bunch of things after the New Year break, but I'll make time to review this PR soon. |
Alright, I've spent a bit of time looking around the changes and here are my thoughts: There are currently 2 ways to customize the Admin UI:
The first method is mainly intended for environment-dependent configuration (api urls etc), whereas the second method is aimed toward functional extensions of the UI via extension modules. These changes fall somewhere in between - they don't extend the UI per se, but they are purely visual changes not related to the underlying configuration of the admin ui. I'm tending to think that (at least some of) this functionality belongs in the
I think your approach (of adding options to AdminUiPlugin) makes sense for the branding options though. Here's what I propose:
|
Make sense move logo, icon and css to ui-devkit, i think that even the user could suply his own scaffold dir, enabling him to make advanced customizations on specifc modules. |
I have reduced the scope of this PR to branding options (brand, hideVendureBranding, hideVersion), as suggested. |
@jeancx Thank you very much for your contribution! Especially the docs - that's really thorough and appreciated. I was thinking of working on the other 2 aspects myself (branding images & styling) unless you have a particularly strong desire to tackle either? |
I just tested today, all workin fine, was a good work, very clean code. |
Closes #391
What this PR does change:
To test: