-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cu 9rvcxw/product variants #563
Closed
hendrik-advantitge
wants to merge
22
commits into
vendure-ecommerce:next
from
advantitge:CU-9rvcxw/ProductVariants
Closed
Cu 9rvcxw/product variants #563
hendrik-advantitge
wants to merge
22
commits into
vendure-ecommerce:next
from
advantitge:CU-9rvcxw/ProductVariants
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to issue #519.
Functional part of transferring from ChannelAware Products to ChannelAware ProductVariants is done.
Tasks that still need to be done:
Would you be able to take some of these tasks off my hands if I focus on writing the new tests?
Any feedback on the implementation is of course welcome.
Thank you very much in advance!
EDIT: seems like branching of master was not such a great idea