Making Orders ChannelAware #440 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrik-advantitge
force-pushed
the
feature/#70vheb
branch
from
f8c7010 to
2731d32
Compare
hendrik-advantitge
force-pushed
the
feature/#70vheb
branch
from
f86747e to
b84a78b
Compare
|
Thank you for the fantastic work on this feature. Especially the thorough e2e test suite. I found the cause of the failing e2e test, and it was the fault of the test, not your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #440 .
Still have an issue where the order is not saved under the default channel. I am however using the ChannelService.AssignToCurrentChannel() method.