Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-devkit) Fix generation of shared module file #318

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix(ui-devkit) Fix generation of shared module file #318

merged 1 commit into from
Apr 23, 2020

Conversation

Tyratox
Copy link
Contributor

@Tyratox Tyratox commented Apr 18, 2020

Describe the bug
When generating the shared extension module the different extension modules are joined together correctly but if one extension contains multiple modules the default join inserts commas which results in a compilation error.

To Reproduce
Export multiple ngModules from one extension.

EDIT: It's the default behavior in JS: https://jsfiddle.net/kyp8L5bx/

Expected behavior
The imports should be joined together with a '' instead of a comma

@michaelbromley
Copy link
Member

Hi, thanks for the PR!

As you might have noticed, the CI failed for no fault of your own. I just pushed a couple of fixes. Would you be so kind as to rebase onto master push again to this PR?

@Tyratox
Copy link
Contributor Author

Tyratox commented Apr 23, 2020

Of course!

@michaelbromley michaelbromley merged commit fd73472 into vendure-ecommerce:master Apr 23, 2020
@Tyratox Tyratox deleted the patch-1 branch May 4, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants