add email event UI triggers for resend option in emails

[monrostar]

Description

#3016

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

👍 Most of the time:

• I have added or updated test cases
• I have updated the README if needed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Aug 28, 2024 11:37am

[michaelbromley]

Note that there is a case that needs to be handled here for arguments of the type ID. Since Vendure has the concept of ID encoding/decoding, we also need to ensure that any ID arguments are correctly decoded before passing them to the createEvent function.

This can be done by injecting the ConfigurableOperationCodec helper and calling decodeConfigurableOperationIds() , passing the handler and args.

The function mutates the arg.value for any IDS. You can see an example of usage here:

vendure/packages/core/src/api/resolvers/admin/promotion.resolver.ts

Line 79 in c539290

this.configurableOperationCodec.decodeConfigurableOperationIds(

[monrostar]

I've added a value parser in this place but there seems to be no ID decode there...

[michaelbromley]

"can be sent"

[monrostar]

done

[michaelbromley]

drop the .

[monrostar]

done

[michaelbromley]

Also, make the PR against the minor branch please 👍

[monrostar]

What I didn't finish:

1. Only a temporary UI for the Order page is made. Not added EmailEventUI to customer
2. Not added Permissions, maybe it is possible to make permissions only for EmailEventResend...?
3. I have done args parsing, but I wanted to discuss how to add ID decode since EmailPlugin has no properties in VendureConfig and maybe you can find a better solution
4. No Errors have been added to the email-event.resolver.ts

[michaelbromley]

Status update from my side:

I pulled this PR locally and tested it out. Basically it looks good but I have a few points I want to spend more time thinking about when I am a little less busy:

• We discussed extracting the UI parts to the EmailPlugin to avoid the coupling. Architecturally this would be correct. DX-wise it would mean more complexity to expose this functionality in the UI.
• In that regard it would be nice to be able to expose this functionality out-of-the-box without requiring to compile the Admin UI.

But in order to bundle this functionality into the Admin UI I'd really only want to do that if the functionality is not specific to the EmailPlugin.

So I'm wondering whether in here there is a more generic concept such as "event replay" which would be more broadly applicable, and then the email re-send is a specific implementation of that.

[monrostar]

Status update from my side:

I pulled this PR locally and tested it out. Basically it looks good but I have a few points I want to spend more time thinking about when I am a little less busy:

• We discussed extracting the UI parts to the EmailPlugin to avoid the coupling. Architecturally this would be correct. DX-wise it would mean more complexity to expose this functionality in the UI.
• In that regard it would be nice to be able to expose this functionality out-of-the-box without requiring to compile the Admin UI.

But in order to bundle this functionality into the Admin UI I'd really only want to do that if the functionality is not specific to the EmailPlugin.

So I'm wondering whether in here there is a more generic concept such as "event replay" which would be more broadly applicable, and then the email re-send is a specific implementation of that.

Do you need help integrating such functionality? And it would be cool to know when we can get such a feature

[michaelbromley]

Just an update as I am going through old PRs this morning: this is still on our "under consideration" lane in the roadmap. For now we have other higher priority features we want to ship but I'm leaving this open because it is fundamentally a good feature.