Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/mollie klarna AutoCapture doesn't work! #2446

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix/mollie klarna AutoCapture doesn't work! #2446

merged 2 commits into from
Oct 12, 2023

Conversation

martijnvdbrug
Copy link
Collaborator

Quite an impactful fix:

  • Somewhere between V1.9 and v2.0.8 the relation order.payments got lost, resulting in Klarna Pay Later orders nver transitioning to PaymentSettled
  • Without this fix orders stay in PaymentAuthorized, and shop owners never receive their money. Klarna has a policy that payments should be captured within 30 days, after that capturing payments (= receiving money) is not possible anymore.
  • A test case is very useful here, but, time... I've added a Todo in the e2e file

@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit ed585c8
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/6527d794e0001200092bad72

@michaelbromley michaelbromley merged commit 8db459a into vendure-ecommerce:master Oct 12, 2023
14 checks passed
@michaelbromley
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijnvdbrug @michaelbromley