Fix #1091

[filipproch]

Fixes #1091

[michaelbromley]

Can we be sure that this will not have unintended consequences? E.g. what if I name my custom field '__mrp'?

Is there an argument against checking for the full string '__typename'?

[filipproch]

GraphQL is using "__" in various places for internal field.

https://graphql.org/learn/introspection/
or
__resolveType

so I felt to future proof it in case there would be some additions to GraphQL spec in the future

[filipproch]

if you prefer just __typename - I will change it

[michaelbromley]

I just had another thought - perhaps a way to avoid the entire issue with the naming convention is to just make the function ignore an undefined inputType on line 133, with const arg of inputType?.args ?? [].

[filipproch]

done

[filipproch]

Sure will try it and update the PR

On October 20, 2021, GitHub ***@***.***> wrote: @michaelbromley commented on this pull request. In packages/core/src/api/middleware/validate-custom-fields- interceptor.ts <https://github.com/vendure- ecommerce/vendure/pull/1178#discussion_r732718666>: @@ -127,7 +127,7 @@ export class ValidateCustomFieldsInterceptor

implements NestInterceptor { const map: { [inputName: string]: string } = {}; for (const selection of operation.selectionSet.selections) { - if (selection.kind === 'Field') { + if (selection.kind === 'Field' && !selection.name.value.startsWith('__')) {

I just had another thought - perhaps a way to avoid the entire issue with the naming convention is to just make the function ignore an undefined inputType on line 133, with const arg of inputType?.args ?? [].

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/vendure- ecommerce/vendure/pull/1178#discussion_r732718666>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAKSU3AOYAWSFG2UMGUHV73UH2YCBANCNFSM5GLMEZSQ>.

[michaelbromley]

Thank you!