Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix shipping price when the promotion is not applicable anymo #1150

Merged
merged 2 commits into from
Oct 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ export class ShippingLine extends VendureEntity {
this.adjustments = this.adjustments.concat(adjustment);
}

removeAdjustments() {
this.adjustments = [];
}

/**
* @description
* The total of all price adjustments. Will typically be a negative number due to discounts.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,11 @@ export class OrderCalculator {
}
}
}
} else {
// If there is no applicable promotion for shipping, we should remove already assigned adjustment from shipping lines.
for (const shippingLine of order.shippingLines) {
shippingLine.removeAdjustments();
}
}
}

Expand Down