Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1054 feat(elasticsearch-plugin): lists in customMappings and custom relations to fetch from DB #1148

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

Izayda
Copy link
Contributor

@Izayda Izayda commented Oct 12, 2021

feat(elasticsearch-plugin): add ability to return lists from customMappings #1054
feat(elasticsearch-plugin): add ability to specify custom relations to fetch from DB #1054
fix(elasticsearch-plugin): log errors text while reindexing #1054

…ppings #870

feat(elasticsearch-plugin): add ability to specify custom relations to fetch from DB #870
fix(elasticsearch-plugin): log errors text while reindexing #870
@michaelbromley
Copy link
Member

michaelbromley commented Oct 12, 2021

This is great! If it is ok with you I will add a few commits of my own in order to make the additionalProductRelationsToFetchFromDB option type-safe, and I might rename those properties to something like hydrateProductRelations to match the pattern of the recently-added EntityHydrator.

update: actually I will just merge now and make other commits on minor as refactorings, this PR basically works as it should 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants