allow custom host id when creating new entity for orderable assets #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbromley
requested changes
Aug 18, 2021
| default: | ||
| return `${camelCase(entityName, true)}Id`; | ||
| } | ||
| } catch (error) { |
There was a problem hiding this comment.
This try-catch block is redundant, since there is no possibility of an error being thrown from the switch statement. You can omit this and just use the switch statement instead.
|
👍 |
simpian
commented
Aug 19, 2021
| @@ -565,8 +568,8 @@ export class AssetService { | |||
| case 'Collection': | |||
| return 'collectionId'; | |||
| default: | |||
| throw new InternalServerError('error.could-not-find-matching-orderable-asset'); | |||
| } | |||
| return `${camelCase(entityName, true)}Id`; | |||
There was a problem hiding this comment.
@michaelbromley I accidentally added true flag in this function, can you please remove true flag that will actually turn the first letter capital making this Title case instead of camelCase,
sorry for the inconvenience, thanks!
michaelbromley
added a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1034