Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin-ui] Dropdowns are often clipped #95

Closed
michaelbromley opened this issue May 14, 2019 · 0 comments
Closed

[admin-ui] Dropdowns are often clipped #95

michaelbromley opened this issue May 14, 2019 · 0 comments
Labels

Comments

@michaelbromley
Copy link
Member

michaelbromley commented May 14, 2019

The clr-dropdown we are using does not detect the edges of the viewport or overlapping divs which causes it to get clipped and become unusable. This is a known issue from the Clarity team and there is an open issue aimed at re-working the whole underlying popover mechanism to fix this: vmware-archive/clarity#2923

However, this task is marked as "post 2.0" (2.0 is currently in RC), so it may be a little while before this is resolved.

For the admin UI this is quite an important issue, as in certain cases a menu will become unusable.

Proposal: re-implement with Angular CDK

The Angular CDK provides an overlay module which will dynamically re-position an element to ensure it is always visible.

It should therefore be possible to use this overlay module to re-implement the subset of the clr-dropdown API using the markup and CSS of the Clarity lib: https://v1.clarity.design/dropdowns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant