Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products listing is not displayed if we change the channel language #883

Closed
rahulpalresha opened this issue May 18, 2021 · 1 comment
Closed
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@rahulpalresha
Copy link

Products listing is not displayed if we change the channel language

Assumptions: Consider default channel language is English (EN)

Steps to reproduce:

  1. Navigate to Catalog > Products
  2. Observe the list of products that are present in the system catalog
  3. Now navigate to Settings > Channels
  4. Change the Default language to say e.g. German (de) or French (fr) considering they are already added in the languages list for the system
  5. Save the changes
  6. Now again navigate to Catalog > Products

Expected behavior

  1. Products listing should not be blank if the channel language is changed

Environment
https://demo.vendure.io/

@rahulpalresha rahulpalresha added the type: bug 🐛 Something isn't working label May 18, 2021
@michaelbromley
Copy link
Member

What is happening here is that the product list is only showing results which have translations in the default channel language. So in your case, if switching to e.g. French, and no Products have yet been translated into French, then you see an empty list.

Perhaps an ideal solution would be to display all products, and display them in the default language of the Channel if available, else display them in some fallback language. However, this might not be feasible with the current way that the search index works.

Another solution (which is a missing feature anyway) would be to add a language selector to the top of the list, allowing you to set the language manually and view all Products translated into that language. I will add this to the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants