Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facet visibility #80

Closed
michaelbromley opened this issue Mar 21, 2019 · 1 comment
Closed

Facet visibility #80

michaelbromley opened this issue Mar 21, 2019 · 1 comment
Labels
type: feature ✨ @vendure/admin-ui @vendure/core

Comments

@michaelbromley
Copy link
Member

There should be a boolean property on Facets which determines whether they are visible via the shop api.

Use case: A facet name "profit margin" with values "highly profitable" etc. is used in the back-end for e.g. Promotion actions or just for internal organization. We might not want to make this info known to the shop customers.
@michaelbromley michaelbromley mentioned this issue Apr 25, 2019
Closed
@michaelbromley
Copy link
Member Author

We will use the isPrivate field, just like with Collections.

The following parts of the shop API must omit private Facets / Values:

  • Product.facetValues - via shop-product.resolver.ts
  • ProductVariant.facetValues - via product-variant-entity.resolver.ts
  • SearchResponse.facetValues - via fulltext-search.resolver.ts

michaelbromley added a commit that referenced this issue Apr 26, 2019
@michaelbromley
feat(core): Implement private Facets
b6c3240 
Relates to #80
michaelbromley added a commit that referenced this issue Apr 26, 2019
@michaelbromley
feat(admin-ui): Add UI controls for private Facets
290a576 
Relates to #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature ✨ @vendure/admin-ui @vendure/core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelbromley