De-couple PaymentMethod from PaymentMethodHandler

[michaelbromley]

The PaymentMethod entity has a "code" field which is supposed to refer to one of the configured PaymentMethodHandlers. However, in the GraphQL API updatePaymentMethod mutation, as well as in the Admin UI, this "code" can be edited.

There seems to be no good reason to allow setting this code. Rather, it would make more sense to de-couple the handler and the method, so that you can create a PaymentMethod and then select from one of the configured handlers.

Additionally, the PaymentMethod should have a "name" and "description" field.

Also add some e2e tests for the PaymentMethodResolver.

[michaelbromley]

While working on this, also handle these related issues: #469, #662

[stefanvanherwijnen]

Could you also add the name and description on the returned eligibleShippingMethods?

vendure/packages/core/src/service/services/payment-method.service.ts

Lines 111 to 116 in c3c5888

	results.push({
	id: method.id,
	code: method.code,
	isEligible,
	eligibilityMessage,
	});

Also, if I understand correctly, code is deprecated and could be removed?

Edit: addPaymentToOrder also requires the code as input, I think this should also be either the name or id?

[michaelbromley]

Could you also add the name and description on the returned eligibleShippingMethods?

@stefanvanherwijnen could you please open a new issue for this so I don't forget about it?

Also, if I understand correctly, code is deprecated and could be removed?

The code property is still needed in the addPaymentToOrder() as you pointed out. True, it might be preferable to use the id instead now, as it is more explicit.