Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTX to PaymentHandler and its methods #488

Closed
chladog opened this issue Oct 8, 2020 · 1 comment
Closed

CTX to PaymentHandler and its methods #488

chladog opened this issue Oct 8, 2020 · 1 comment
Labels
@vendure/core
Milestone
v0.17.0

Comments

@chladog
Copy link
Contributor

chladog commented Oct 8, 2020

Is your feature request related to a problem? Please describe.
No ctx object passed to PaymentHandler

Describe the solution you'd like
CTX object passed to PaymentHandler and its methods (createPayment, refund...)
for example we want to have languageCode available so we can passi to the payment provider that can provide URL to localized gateway.

Describe alternatives you've considered
Passing settings in metadata, but it redundant if we already have ctx object...
@michaelbromley michaelbromley added this to the v0.17.0 milestone Oct 15, 2020
@chladog
Copy link
Contributor Author

chladog commented Oct 20, 2020 •
edited
Loading

With release v16 this gets even greater relevance as data services require CTX object to be passed as parameter.

michaelbromley added a commit that referenced this issue Oct 27, 2020
@michaelbromley
feat(core): Pass RequestContext to PaymentMethodHandler functions
9c2257d 
Closes #488

BREAKING CHANGE: The `PaymentMethodHandler` function signatures have changed:
`createPayment()`, `settlePayment()` & `createRefund()` now all get passed the
RequestContext object as the first argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@vendure/core
Projects
None yet
Milestone
v0.17.0
Development

No branches or pull requests
2 participants
@michaelbromley @chladog