Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PriceCalculationStrategy.calculateUnitPrice - pass new parameters: ctx, orderid, activechannelid... #487

Closed
BetMan100 opened this issue Oct 8, 2020 · 0 comments
Closed

PriceCalculationStrategy.calculateUnitPrice - pass new parameters: ctx, orderid, activechannelid... #487

BetMan100 opened this issue Oct 8, 2020 · 0 comments
Labels
@vendure/core
Milestone
v0.17.0

Comments

@BetMan100
Copy link

In my special PriceCalculationStrategy I would like to have information about the current context, activechannel because different channels have different pricing method. The calculateUnitPrice function parameters should be extended. The caller function (adjustOrderLine) already have the information

vendure/packages/core/src/service/services/order.service.ts

Line 368 in b275c20

const calculatedPrice = await priceCalculationStrategy.calculateUnitPrice(

@michaelbromley michaelbromley added this to the v0.17.0 milestone Oct 8, 2020
michaelbromley added a commit that referenced this issue Oct 27, 2020
@michaelbromley
feat(core): Pass RequestContext to PriceCalculationStrategy
8a58325 
Closes #487

BREAKING CHANGE: The `PriceCalculationStrategy.calculateUnitPrice()` function
signature has changed: the first argument is now the RequestContext of the current request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@vendure/core
Projects
None yet
Milestone
v0.17.0
Development

No branches or pull requests
2 participants
@michaelbromley @BetMan100