Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker health check #289

Closed
michaelbromley opened this issue Mar 30, 2020 · 2 comments
Closed

Worker health check #289

michaelbromley opened this issue Mar 30, 2020 · 2 comments

Comments

@michaelbromley
Copy link
Member

Is your feature request related to a problem? Please describe.
If the worker process is not running, certain operations (e.g. updating prod search index) will fail. This can be confusing as it is not immediately obvious why they fail, and could be a common source of frustration.

Describe the solution you'd like
Add a new query which tests the readiness of the worker process. In the Admin UI, run this on bootstrap and raise a warning if not available.

@michaelbromley
Copy link
Member Author

michaelbromley commented Mar 30, 2020

While I implement this I'll make it part of a general health check query. This will provide data on the health of the server & worker publicly, and perhaps we can include more granular data on particular services (database, elasticsearch) but restricted to authorized admins.

Makes sense to integrate the Nest Terminus package (https://docs.nestjs.com/recipes/terminus). It's well-documented and supports microservices (ie the worker process) out of the box, and should ready Vendure for use with Kubernetes.

@michaelbromley
Copy link
Member Author

Note: wait for official Nest v7 compatibility of the Terminus module: nestjs/terminus#606

This means this feature will be deferred to a later minor release (as Nest v7 is due in the next minor)

@michaelbromley michaelbromley added this to the v0.12.0 milestone Apr 15, 2020
@michaelbromley michaelbromley modified the milestones: v0.12.0, v1.0.0 Apr 23, 2020
michaelbromley added a commit that referenced this issue May 5, 2020
michaelbromley added a commit that referenced this issue May 5, 2020
michaelbromley added a commit that referenced this issue May 5, 2020
michaelbromley added a commit that referenced this issue May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant