Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear "permission denied" error missing in admin-ui #246

Closed
lsimone opened this issue Jan 18, 2020 · 1 comment
Closed

clear "permission denied" error missing in admin-ui #246

lsimone opened this issue Jan 18, 2020 · 1 comment
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@lsimone
Copy link
Contributor

lsimone commented Jan 18, 2020

Describe the bug
When permissions are not adequately set, and a vendure user has no read access to some resources, no permission error is shown.
admin-ui just shows white page.

To Reproduce
[admin-ui]

  1. create a user without read permissions (i.e: Promotion read permission disabled)
  2. go to order detail page

Expected behavior
A "permission denied" error would be enough IMHO.

Additional context
image

@lsimone lsimone added the type: bug 🐛 Something isn't working label Jan 18, 2020
@michaelbromley
Copy link
Member

I cannot reproduce the behaviour in the screenshot based on the instructions given. When viewing an Order detail, no call is made for any Promotion data.

Currently, if you try to access a resource you do not have permissions on in the Admin UI, you will be immediately logged out. This is also perhaps not ideal, but is a slightly different issue to the one described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants