Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job error of session for user with no product/category/job based permissions #2456

Closed
BeepLoveKarki opened this issue Oct 16, 2023 · 1 comment · Fixed by #2460
Closed

Job error of session for user with no product/category/job based permissions #2456

BeepLoveKarki opened this issue Oct 16, 2023 · 1 comment · Fixed by #2460
Assignees
@michaelbromley
Labels
type: bug 🐛 Something isn't working

Comments

@BeepLoveKarki
Copy link
Contributor

BeepLoveKarki commented Oct 16, 2023 •
edited
Loading

When I create a new role with no permissions related to a product, category, or job, I get no pendingSearchIndexUpdates error and the admin is logged out automatically.

This didn't happen on prior versions.
@BeepLoveKarki BeepLoveKarki added the type: bug 🐛 Something isn't working label Oct 16, 2023
@jnugh
Copy link
Contributor

jnugh commented Oct 17, 2023

We've got the same issue. This happens because the pendingSearchIndexUpdates query requires Permission.ReadCatalog or Permission.ReadProduct.
I'll open a PR that adds a permission check when configuring new alerts.

@jnugh jnugh mentioned this issue Oct 17, 2023
Merged
michaelbromley pushed a commit that referenced this issue Oct 17, 2023
@jnugh
fix(admin-ui): Do not load pending search index updates if permission…
08ad982 
…s are insufficient (#2460)

Fixes #2456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbromley michaelbromley

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@jnugh @michaelbromley @BeepLoveKarki