Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TaxRate.value to float #234

Closed
oncode opened this issue Dec 26, 2019 · 1 comment
Closed

Change TaxRate.value to float #234

oncode opened this issue Dec 26, 2019 · 1 comment
Labels
@vendure/core

Comments

@oncode
Copy link
Contributor

oncode commented Dec 26, 2019

Would it be possible to change the value attribute of the TaxRate unit to Float instead of Int? The taxes in Switzerland are 7.7% and an error occurs if I want to save it. Thanks for your awesome work!
@michaelbromley
Copy link
Member

Hi,

Yes, that's a good point, it should be a Float type. I'll make this change in the next release.

michaelbromley added a commit that referenced this issue Jan 28, 2020
@michaelbromley
feat(core): Use decimal type for OrderItem.taxRate
92650ec 
Relates to #234.

BREAKING CHANGE: The `OrderItem.taxRate` column type in the database has been changed from `int` to `decimal`. You will need to perform a migration to update this column and depending on your database type, you may need to manually edit the migration script in order to preserve the old values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@vendure/core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oncode @michaelbromley