Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Custom Fields for Plugins #1848

Closed
chregu opened this issue Oct 23, 2022 · 0 comments
Closed

Feat: Custom Fields for Plugins #1848

chregu opened this issue Oct 23, 2022 · 0 comments

Comments

@chregu
Copy link
Contributor

chregu commented Oct 23, 2022

Is your feature request related to a problem? Please describe.

Vendure plugins currently can't use the custom fields feature as core entities can. That's not a big deal, if you're just writing a plugin for your project. But if one wants to publish is as npm package for others to be used, that would be a nice feature. Currently, this is not possible

Describe the solution you'd like

Plugins can use the possibilities of custom fields, like the core plugins can.

Describe alternatives you've considered
Alternative would be to build such a solution for a plugin via it's config options, seems to be a pretty big task for each plugin wanting need.

@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Oct 23, 2022
@michaelbromley michaelbromley moved this from 📅 Planned to 🏗 In progress in Vendure OS Roadmap Jan 24, 2024
michaelbromley added a commit that referenced this issue Jan 25, 2024
Relates to #1848. Rather than relying on a set of hard-coded entities that
we need to register custom fields on, we take advantage of the TypeORM
metadata available to us at runtime in order to dynamically derive the same
configuration.

This opens the door to support for custom fields on user-defined entities.
michaelbromley added a commit that referenced this issue Jan 25, 2024
Relates to #1848. This format allows us to support arbitrary entity names
when getting the custom field config in the Admin UI
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Jan 25, 2024
@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚀 Shipped
Development

No branches or pull requests

2 participants