Skip to content

Commit

Permalink
chore: Publish v0.17.0
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelbromley committed Nov 13, 2020
1 parent 92b6e64 commit f8eb11f
Show file tree
Hide file tree
Showing 14 changed files with 158 additions and 38 deletions.
120 changes: 120 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,123 @@
## 0.17.0 (2020-11-13)


#### Fixes

* **admin-ui** Add missing "authorized" state translation ([788ba87](https://github.com/vendure-ecommerce/vendure/commit/788ba87))
* **admin-ui** Add missing "state.error" token ([b40843a](https://github.com/vendure-ecommerce/vendure/commit/b40843a))
* **admin-ui** Fix payment states ([df32ba1](https://github.com/vendure-ecommerce/vendure/commit/df32ba1))
* **admin-ui** Fix permission handling in nav menu ([70037e5](https://github.com/vendure-ecommerce/vendure/commit/70037e5))
* **admin-ui** Use select control for string custom field with options ([5c59b67](https://github.com/vendure-ecommerce/vendure/commit/5c59b67)), closes [#546](https://github.com/vendure-ecommerce/vendure/issues/546)
* **admin-ui** Use the ShippingMethod name in fulfillment dialog ([ca2ed58](https://github.com/vendure-ecommerce/vendure/commit/ca2ed58))
* **admin-ui** Use translated state labels in custom filter select ([5f6f9ff](https://github.com/vendure-ecommerce/vendure/commit/5f6f9ff))
* **core** Allow configurable stock allocation logic ([782c0f4](https://github.com/vendure-ecommerce/vendure/commit/782c0f4)), closes [#550](https://github.com/vendure-ecommerce/vendure/issues/550)
* **core** Correctly cascade deletions in HistoryEntries ([6054b71](https://github.com/vendure-ecommerce/vendure/commit/6054b71))
* **core** Correctly encode IDs in nested fragments ([d2333fc](https://github.com/vendure-ecommerce/vendure/commit/d2333fc))
* **core** Correctly update cache in customerGroup promo condition ([8df4fec](https://github.com/vendure-ecommerce/vendure/commit/8df4fec))
* **core** Fix double-allocation of stock on 2-stage payments ([c43a343](https://github.com/vendure-ecommerce/vendure/commit/c43a343)), closes [#550](https://github.com/vendure-ecommerce/vendure/issues/550)
* **core** Mitigate QueryRunnerAlreadyReleasedError in EventBus handlers ([739e56c](https://github.com/vendure-ecommerce/vendure/commit/739e56c)), closes [#520](https://github.com/vendure-ecommerce/vendure/issues/520)
* **core** Validate all Role permissions on bootstrap ([60c8a0e](https://github.com/vendure-ecommerce/vendure/commit/60c8a0e)), closes [#450](https://github.com/vendure-ecommerce/vendure/issues/450)

#### Features

* **admin-ui** Account for stockOnHand when creating Fulfillments ([540d2c6](https://github.com/vendure-ecommerce/vendure/commit/540d2c6)), closes [#319](https://github.com/vendure-ecommerce/vendure/issues/319)
* **admin-ui** Add filter presets to the OrderDetail view ([4f5a440](https://github.com/vendure-ecommerce/vendure/commit/4f5a440)), closes [#477](https://github.com/vendure-ecommerce/vendure/issues/477)
* **admin-ui** Allow the setting of custom Permissions ([d525a32](https://github.com/vendure-ecommerce/vendure/commit/d525a32)), closes [#450](https://github.com/vendure-ecommerce/vendure/issues/450)
* **admin-ui** Display Fulfillment custom fields ([838943e](https://github.com/vendure-ecommerce/vendure/commit/838943e)), closes [#525](https://github.com/vendure-ecommerce/vendure/issues/525)
* **admin-ui** Implement UI controls for setting outOfStockThreshold ([335c345](https://github.com/vendure-ecommerce/vendure/commit/335c345)), closes [#319](https://github.com/vendure-ecommerce/vendure/issues/319)
* **admin-ui** Support for ShippingMethod translations & custom fields ([e189bd4](https://github.com/vendure-ecommerce/vendure/commit/e189bd4)), closes [#530](https://github.com/vendure-ecommerce/vendure/issues/530)
* **admin-ui** Support new API for ProductVariant.trackInventory ([b825df1](https://github.com/vendure-ecommerce/vendure/commit/b825df1))
* **core** Add `shouldRunCheck` function to ShippingEligibilityChecker ([3b7e7db](https://github.com/vendure-ecommerce/vendure/commit/3b7e7db)), closes [#536](https://github.com/vendure-ecommerce/vendure/issues/536)
* **core** Add tax summary data to Order type ([a666fab](https://github.com/vendure-ecommerce/vendure/commit/a666fab)), closes [#467](https://github.com/vendure-ecommerce/vendure/issues/467)
* **core** Allow custom Permissions to be defined ([1baeedf](https://github.com/vendure-ecommerce/vendure/commit/1baeedf)), closes [#450](https://github.com/vendure-ecommerce/vendure/issues/450)
* **core** Emit event when assigning/removing Customer to/from group ([6676335](https://github.com/vendure-ecommerce/vendure/commit/6676335))
* **core** Enable inventory tracking by default in GlobalSettings ([31bb06a](https://github.com/vendure-ecommerce/vendure/commit/31bb06a))
* **core** Export custom entity field types ([21706b3](https://github.com/vendure-ecommerce/vendure/commit/21706b3))
* **core** Export HistoryService ([8688c35](https://github.com/vendure-ecommerce/vendure/commit/8688c35))
* **core** Export StockMovementService ([fe98c79](https://github.com/vendure-ecommerce/vendure/commit/fe98c79)), closes [#550](https://github.com/vendure-ecommerce/vendure/issues/550)
* **core** Expose additional price & tax data on OrderLine ([c870684](https://github.com/vendure-ecommerce/vendure/commit/c870684)), closes [#467](https://github.com/vendure-ecommerce/vendure/issues/467)
* **core** Expose assignable Permissions via ServerConfig type ([ab2f62c](https://github.com/vendure-ecommerce/vendure/commit/ab2f62c)), closes [#450](https://github.com/vendure-ecommerce/vendure/issues/450)
* **core** Implement `in` string filter for PaginatedList queries ([7c7dcf2](https://github.com/vendure-ecommerce/vendure/commit/7c7dcf2)), closes [#543](https://github.com/vendure-ecommerce/vendure/issues/543)
* **core** Implement `regex` string filter for PaginatedList queries ([0a33441](https://github.com/vendure-ecommerce/vendure/commit/0a33441)), closes [#543](https://github.com/vendure-ecommerce/vendure/issues/543)
* **core** Implement constraints on adding & fulfilling OrderItems ([87d07f8](https://github.com/vendure-ecommerce/vendure/commit/87d07f8)), closes [#319](https://github.com/vendure-ecommerce/vendure/issues/319)
* **core** Implement inheritance for ProductVariant.trackInventory ([f27f985](https://github.com/vendure-ecommerce/vendure/commit/f27f985))
* **core** Improve feedback & error handling in migration functions ([7a1773c](https://github.com/vendure-ecommerce/vendure/commit/7a1773c))
* **core** Make ShippingMethod translatable ([c7418d1](https://github.com/vendure-ecommerce/vendure/commit/c7418d1)), closes [#530](https://github.com/vendure-ecommerce/vendure/issues/530)
* **core** New "Created" initial state for Fulfillments ([a53f27e](https://github.com/vendure-ecommerce/vendure/commit/a53f27e)), closes [#510](https://github.com/vendure-ecommerce/vendure/issues/510)
* **core** New "Created" initial state for Orders ([7a774e3](https://github.com/vendure-ecommerce/vendure/commit/7a774e3)), closes [#510](https://github.com/vendure-ecommerce/vendure/issues/510)
* **core** OrderItem.unitPrice now _always_ excludes tax ([6e2d490](https://github.com/vendure-ecommerce/vendure/commit/6e2d490)), closes [#467](https://github.com/vendure-ecommerce/vendure/issues/467)
* **core** Pass RequestContext to AssetNamingStrategy functions ([48ae372](https://github.com/vendure-ecommerce/vendure/commit/48ae372))
* **core** Pass RequestContext to AssetPreviewStrategy functions ([05e6f9e](https://github.com/vendure-ecommerce/vendure/commit/05e6f9e))
* **core** Pass RequestContext to AuthenticationStrategy.onLogOut() ([a46ea5d](https://github.com/vendure-ecommerce/vendure/commit/a46ea5d))
* **core** Pass RequestContext to OrderMergeStrategy functions ([eae71f0](https://github.com/vendure-ecommerce/vendure/commit/eae71f0))
* **core** Pass RequestContext to PaymentMethodHandler functions ([9c2257d](https://github.com/vendure-ecommerce/vendure/commit/9c2257d)), closes [#488](https://github.com/vendure-ecommerce/vendure/issues/488)
* **core** Pass RequestContext to PriceCalculationStrategy ([8a58325](https://github.com/vendure-ecommerce/vendure/commit/8a58325)), closes [#487](https://github.com/vendure-ecommerce/vendure/issues/487)
* **core** Pass RequestContext to PromotionAction functions ([0a35a12](https://github.com/vendure-ecommerce/vendure/commit/0a35a12))
* **core** Pass RequestContext to ShippingCalculator functions ([6eee894](https://github.com/vendure-ecommerce/vendure/commit/6eee894))
* **core** Pass RequestContext to ShippingEligibilityChecker functions ([a5db022](https://github.com/vendure-ecommerce/vendure/commit/a5db022))
* **core** Pass RequestContext to TaxZoneStrategy functions ([a4d4311](https://github.com/vendure-ecommerce/vendure/commit/a4d4311))
* **core** Return ErrorResult when setting ineligible ShippingMethod ([0e09d51](https://github.com/vendure-ecommerce/vendure/commit/0e09d51))
* **core** Support custom fields on Fulfillment entity ([380f68e](https://github.com/vendure-ecommerce/vendure/commit/380f68e)), closes [#525](https://github.com/vendure-ecommerce/vendure/issues/525)
* **core** Track stock allocations ([75e3f9c](https://github.com/vendure-ecommerce/vendure/commit/75e3f9c)), closes [#319](https://github.com/vendure-ecommerce/vendure/issues/319)

#### Perf

* **core** Optimize invocation of ShippingEligibilityCheckers ([11415e6](https://github.com/vendure-ecommerce/vendure/commit/11415e6)), closes [#536](https://github.com/vendure-ecommerce/vendure/issues/536)


### BREAKING CHANGE

* Deletions of Orders or Customers now cascade to any associated HistoryEntries,
thus preserving referential integrity. This involves a DB schema change which will necessitate
a migration.
* Fulfillments now start in the new "Created" state, and then _immediately_
transition to the "Pending" state. This allows e.g. event listeners to pick up newly-created
Fulfillments.
* Orders now start in the new "Created" state, and then _immediately_ transition
to the "AddingItems" state. This allows e.g. event listeners to pick up newly-created Orders.
* The `AuthenticationStrategy.onLogOut()` function
signature has changed: the first argument is now the RequestContext of the current request.
* The `OrderItem.unitPrice` is now _always_ given as the net (without tax) price
of the related ProductVariant. Formerly, it was either the net or gross price, depending on
the `pricesIncludeTax` setting of the Channel. If you have existing Orders where
`unitPriceIncludesTax = true`, you will need to manually update the `unitPrice` value *before*
running any other migrations for this release. The query will look like:

`UPDATE order_item SET unitPrice = ROUND(unitPrice / ((taxRate + 100) / 100)) WHERE unitPriceIncludesTax = 1`
* The `OrderLine.totalPrice` field has been deprecated and will be removed in a
future release. Use the new `OrderLine.linePriceWithTax` field instead.
* The `PaymentMethodHandler` function signatures have changed:
`createPayment()`, `settlePayment()` & `createRefund()` now all get passed the
RequestContext object as the first argument.
* The `PriceCalculationStrategy.calculateUnitPrice()` function
signature has changed: the first argument is now the RequestContext of the current request.
* The `ProductVariant.trackInventory` field is now an Enum rather than a boolean, allowing explicit inheritance of the value set in GlobalSettings. This will require a DB migration with a custom query to transform the previous boolean values to the new enum (string) values of "TRUE", "FALSE" or "INHERIT". Check the release blog post for more details.
* The `ShippingMethod` entity is now translatable. This change will require a DB
migration to be performed, including custom queries to migrate any existing ShippingMethods
to the new table structure (see release blog post for details).
* The AssetNamingStrategy `generateSourceFileName()` & `generatePreviewFileName()`
function signatures have changed: the first argument is now the
RequestContext of the current request.
* The AssetPreviewStrategy `generatePreviewImage()`
function signature has changed: the first argument is now the
RequestContext of the current request.
* The internal handling of stock movements has been refined,
which required changes to the DB schema. This will require a migration.
* The OrderMergeStrategy `merge()`
function signature has changed: the first argument is now the
RequestContext of the current request.
* The PromotionAction `execute()`
function signature has changed: the first argument is now the
RequestContext of the current request.
* The ShippingCalculator `calculate()`
function signature has changed: the first argument is now the
RequestContext of the current request.
* The ShippingEligibilityChecker `check()`
function signature has changed: the first argument is now the
RequestContext of the current request.
* The TaxZoneStrategy `determineTaxZone()`
function signature has changed: the first argument is now the
RequestContext of the current request.
## <small>0.16.3 (2020-11-05)</small>


Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"packages": [
"packages/*"
],
"version": "0.16.3",
"version": "0.17.0",
"npmClient": "yarn",
"useWorkspaces": true,
"command": {
Expand Down
6 changes: 3 additions & 3 deletions packages/admin-ui-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/admin-ui-plugin",
"version": "0.16.3",
"version": "0.17.0",
"main": "lib/index.js",
"types": "lib/index.d.ts",
"files": [
Expand All @@ -19,8 +19,8 @@
"devDependencies": {
"@types/express": "^4.17.8",
"@types/fs-extra": "^9.0.1",
"@vendure/common": "^0.16.2",
"@vendure/core": "^0.16.3",
"@vendure/common": "^0.17.0",
"@vendure/core": "^0.17.0",
"express": "^4.17.1",
"rimraf": "^3.0.2",
"typescript": "4.0.3"
Expand Down
4 changes: 2 additions & 2 deletions packages/admin-ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/admin-ui",
"version": "0.16.3",
"version": "0.17.0",
"license": "MIT",
"scripts": {
"ng": "ng",
Expand Down Expand Up @@ -36,7 +36,7 @@
"@ng-select/ng-select": "^5.0.3",
"@ngx-translate/core": "^13.0.0",
"@ngx-translate/http-loader": "^6.0.0",
"@vendure/common": "^0.16.2",
"@vendure/common": "^0.17.0",
"@webcomponents/custom-elements": "^1.2.4",
"apollo-angular": "^2.0.4",
"apollo-upload-client": "^12.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/admin-ui/src/lib/core/src/common/version.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// Auto-generated by the set-version.js script.
export const ADMIN_UI_VERSION = '0.16.3';
export const ADMIN_UI_VERSION = '0.17.0';
6 changes: 3 additions & 3 deletions packages/asset-server-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/asset-server-plugin",
"version": "0.16.3",
"version": "0.17.0",
"main": "lib/index.js",
"types": "lib/index.d.ts",
"files": [
Expand All @@ -22,8 +22,8 @@
"@types/fs-extra": "^9.0.1",
"@types/node-fetch": "^2.5.7",
"@types/sharp": "^0.26.0",
"@vendure/common": "^0.16.2",
"@vendure/core": "^0.16.3",
"@vendure/common": "^0.17.0",
"@vendure/core": "^0.17.0",
"aws-sdk": "^2.766.0",
"express": "^4.17.1",
"node-fetch": "^2.6.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/common/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/common",
"version": "0.16.2",
"version": "0.17.0",
"main": "index.js",
"license": "MIT",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/core",
"version": "0.16.3",
"version": "0.17.0",
"description": "A modern, headless ecommerce framework",
"repository": {
"type": "git",
Expand Down Expand Up @@ -48,7 +48,7 @@
"@nestjs/testing": "7.4.4",
"@nestjs/typeorm": "7.1.3",
"@types/fs-extra": "^9.0.1",
"@vendure/common": "^0.16.2",
"@vendure/common": "^0.17.0",
"apollo-server-express": "2.18.1",
"bcrypt": "^5.0.0",
"body-parser": "^1.19.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/create/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/create",
"version": "0.16.3",
"version": "0.17.0",
"license": "MIT",
"bin": {
"create": "./index.js"
Expand All @@ -26,13 +26,13 @@
"@types/handlebars": "^4.1.0",
"@types/listr": "^0.14.2",
"@types/semver": "^6.2.2",
"@vendure/core": "^0.16.3",
"@vendure/core": "^0.17.0",
"rimraf": "^3.0.2",
"ts-node": "^9.0.0",
"typescript": "4.0.3"
},
"dependencies": {
"@vendure/common": "^0.16.2",
"@vendure/common": "^0.17.0",
"chalk": "^4.1.0",
"commander": "^6.1.0",
"cross-spawn": "^7.0.3",
Expand Down
18 changes: 9 additions & 9 deletions packages/dev-server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dev-server",
"version": "0.16.3",
"version": "0.17.0",
"main": "index.js",
"license": "MIT",
"private": true,
Expand All @@ -14,18 +14,18 @@
"load-test:100k": "node -r ts-node/register load-testing/run-load-test.ts 100000"
},
"dependencies": {
"@vendure/admin-ui-plugin": "^0.16.3",
"@vendure/asset-server-plugin": "^0.16.3",
"@vendure/common": "^0.16.2",
"@vendure/core": "^0.16.3",
"@vendure/elasticsearch-plugin": "^0.16.3",
"@vendure/email-plugin": "^0.16.3",
"@vendure/admin-ui-plugin": "^0.17.0",
"@vendure/asset-server-plugin": "^0.17.0",
"@vendure/common": "^0.17.0",
"@vendure/core": "^0.17.0",
"@vendure/elasticsearch-plugin": "^0.17.0",
"@vendure/email-plugin": "^0.17.0",
"typescript": "4.0.3"
},
"devDependencies": {
"@types/csv-stringify": "^3.1.0",
"@vendure/testing": "^0.16.3",
"@vendure/ui-devkit": "^0.16.3",
"@vendure/testing": "^0.17.0",
"@vendure/ui-devkit": "^0.17.0",
"concurrently": "^5.0.0",
"csv-stringify": "^5.3.3"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/elasticsearch-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/elasticsearch-plugin",
"version": "0.16.3",
"version": "0.17.0",
"license": "MIT",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand All @@ -22,8 +22,8 @@
"deepmerge": "^4.2.2"
},
"devDependencies": {
"@vendure/common": "^0.16.2",
"@vendure/core": "^0.16.3",
"@vendure/common": "^0.17.0",
"@vendure/core": "^0.17.0",
"rimraf": "^3.0.2",
"typescript": "4.0.3"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/email-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/email-plugin",
"version": "0.16.3",
"version": "0.17.0",
"license": "MIT",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -33,8 +33,8 @@
"@types/handlebars": "^4.1.0",
"@types/mjml": "^4.0.4",
"@types/nodemailer": "^6.4.0",
"@vendure/common": "^0.16.2",
"@vendure/core": "^0.16.3",
"@vendure/common": "^0.17.0",
"@vendure/core": "^0.17.0",
"rimraf": "^3.0.2",
"typescript": "4.0.3"
}
Expand Down
6 changes: 3 additions & 3 deletions packages/testing/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/testing",
"version": "0.16.3",
"version": "0.17.0",
"description": "End-to-end testing tools for Vendure projects",
"keywords": [
"vendure",
Expand Down Expand Up @@ -33,7 +33,7 @@
},
"dependencies": {
"@types/node-fetch": "^2.5.4",
"@vendure/common": "^0.16.2",
"@vendure/common": "^0.17.0",
"faker": "^4.1.0",
"form-data": "^3.0.0",
"graphql": "15.3.0",
Expand All @@ -44,7 +44,7 @@
"devDependencies": {
"@types/mysql": "^2.15.15",
"@types/pg": "^7.14.5",
"@vendure/core": "^0.16.3",
"@vendure/core": "^0.17.0",
"mysql": "^2.18.1",
"pg": "^8.4.0",
"rimraf": "^3.0.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/ui-devkit/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@vendure/ui-devkit",
"version": "0.16.3",
"version": "0.17.0",
"description": "A library for authoring Vendure Admin UI extensions",
"keywords": [
"vendure",
Expand Down Expand Up @@ -39,8 +39,8 @@
"@angular/cli": "^10.1.4",
"@angular/compiler": "^10.1.4",
"@angular/compiler-cli": "^10.1.4",
"@vendure/admin-ui": "^0.16.3",
"@vendure/common": "^0.16.2",
"@vendure/admin-ui": "^0.17.0",
"@vendure/common": "^0.17.0",
"chalk": "^4.1.0",
"chokidar": "^3.4.2",
"fs-extra": "^9.0.1",
Expand All @@ -51,7 +51,7 @@
"@rollup/plugin-node-resolve": "^9.0.0",
"@types/fs-extra": "^9.0.1",
"@types/glob": "^7.1.3",
"@vendure/core": "^0.16.3",
"@vendure/core": "^0.17.0",
"rimraf": "^3.0.2",
"rollup": "^2.28.2",
"rollup-plugin-terser": "^7.0.2",
Expand Down

0 comments on commit f8eb11f

Please sign in to comment.