fix(core): Fix findByIdsInChannel to take ids into account (#365)

vendure-ecommerce · Jun 8, 2020 · dd4bbc9 · dd4bbc9
1 parent f385d69
commit dd4bbc9
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/core/src/service/helpers/utils/channel-aware-orm-utils.ts b/packages/core/src/service/helpers/utils/channel-aware-orm-utils.ts
@@ -16,6 +16,12 @@ export function findByIdsInChannel<T extends ChannelAware | VendureEntity>(
     findOptions?: FindManyOptions<T>,
     eager = true,
 ) {
+    //the syntax described in https://github.com/typeorm/typeorm/issues/1239#issuecomment-366955628
+    //breaks if the array is empty
+    if(ids.length === 0){
+        return Promise.resolve([]);
+    }
+
     const qb = connection.getRepository(entity).createQueryBuilder('product');
     FindOptionsUtils.applyFindManyOptionsOrConditionsToQueryBuilder(qb, findOptions);
     if (eager) {
@@ -24,6 +30,7 @@ export function findByIdsInChannel<T extends ChannelAware | VendureEntity>(
     }
     return qb
         .leftJoin('product.channels', 'channel')
+        .andWhere("product.id IN (:...ids)", { ids })
         .andWhere('channel.id = :channelId', { channelId })
         .getMany();
 }