fix(common): Correctly normalize strings with single quotes

Closes #679
vendure-ecommerce · Feb 4, 2021 · 00e0ad9 · 00e0ad9
1 parent 8a1ff82
commit 00e0ad9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/common/src/normalize-string.spec.ts b/packages/common/src/normalize-string.spec.ts
@@ -29,4 +29,10 @@ describe('normalizeString()', () => {
     it('allows a subset of non-alphanumeric characters to pass through', () => {
         expect(normalizeString('-_.')).toBe('-_.');
     });
+
+    // https://github.com/vendure-ecommerce/vendure/issues/679
+    it('replaces single quotation marks', () => {
+        expect(normalizeString('Capture d’écran')).toBe('capture decran');
+        expect(normalizeString('Capture d‘écran')).toBe('capture decran');
+    });
 });
diff --git a/packages/common/src/normalize-string.ts b/packages/common/src/normalize-string.ts
@@ -8,6 +8,6 @@ export function normalizeString(input: string, spaceReplacer = ' '): string {
         .normalize('NFD')
         .replace(/[\u0300-\u036f]/g, '')
         .toLowerCase()
-        .replace(/[!"£$%^&*()+[\]{};:@#~?\\/,|><`¬'=]/g, '')
+        .replace(/[!"£$%^&*()+[\]{};:@#~?\\/,|><`¬'=‘’]/g, '')
         .replace(/\s+/g, spaceReplacer);
 }