Make inspector work parallel #248
Conversation
| fn inspect_data_raw<Data: AsRef<[u8]>>(&self, key: Vec<u8>, value: Data) -> Result<()>; | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy, Eq, PartialEq, Ord, PartialOrd)] |
There was a problem hiding this comment.
Eq, Ord, PartialOrd, and even PartialEq instances are unnecessary.
| } | ||
|
|
||
| pub mod memorizer { | ||
| pub trait TrieDataInsectorRaw { | ||
| fn inspect_data_raw<Data: AsRef<[u8]>>(&self, key: Vec<u8>, value: Data) -> Result<()>; |
There was a problem hiding this comment.
Probably key should be also typed as AsRef<[u8]>
|
|
||
| for (key, _data) in db.iterator(rocksdb::IteratorMode::Start) { | ||
| let bytes = <&[u8; 32]>::try_from(key.as_ref())?; | ||
| let key = H256::from(bytes); |
There was a problem hiding this comment.
there is no try_from_slice in H256 afaik
There was a problem hiding this comment.
Already implemented. In this PR.
=)
ledger-tool/src/evm_state.rs
Outdated
| { | ||
| storages_walker.traverse(*storage_root)?; | ||
| } | ||
| info!("Total trie nodes info:"); |
There was a problem hiding this comment.
Header should be part of summarize() call.
There was a problem hiding this comment.
TrieCollector is generic enough, and don't have info about type of trie that it collect.
There was a problem hiding this comment.
This info line doesn't contains any type specific info.
There was a problem hiding this comment.
fn summarize(&self) where K: Debug or something like this.
vldm
force-pushed
the
make-inspector-parallel
branch
from
b0ab845
to
2c18bc0
Compare
No description provided.