-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@wordpress/scripts を 28.4.0 にアップデート #2154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drill-lancer
changed the title
Test/@wordpress/scripts/28
【確認待ち】@wordpress/scripts を 28.4.0 にアップデート
Aug 5, 2024
drill-lancer
requested review from
mthaichi,
kurudrive,
sysbird,
goutetsuguma and
mtdkei
August 5, 2024 04:32
mtdkei
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mtdkei
changed the title
【確認待ち】@wordpress/scripts を 28.4.0 にアップデート
【2人目確認待ち】@wordpress/scripts を 28.4.0 にアップデート
Aug 6, 2024
6 tasks
sysbird
changed the title
【2人目確認待ち】@wordpress/scripts を 28.4.0 にアップデート
【2人目確認中】@wordpress/scripts を 28.4.0 にアップデート
Aug 6, 2024
sysbird
approved these changes
Aug 6, 2024
sysbird
changed the title
【2人目確認中】@wordpress/scripts を 28.4.0 にアップデート
@wordpress/scripts を 28.4.0 にアップデート
Aug 6, 2024
対応ありがとうございます! マージしますね |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
#2152
どういう変更をしたか?
スクリーンショットまたは動画
変更前 Before
変更後 After
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
⇒ @wordpress/scripts を 28.4.0 に更新したのみなので省略
変更内容について何を確認したか、どういう方法で確認をしたかなど
以上を確認しました。
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
以上を確認お願いします。
レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。