ブログカードブロック 追加 #1778
Merged
ブログカードブロック 追加 #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
再利用ブロックが含まれたページで置換がおかしくなるバグ修正
パフォーマンス上問題なかったので内部リンクはキャッシュ機能を使わない
decodeEntities
decodeEntities
一旦テスト解除
phpunit test
phpunit test
phpunit test
phpunit test
phpunit test
余計なattributesを削除
shimotmk
commented
Aug 30, 2023
| "default": "" | ||
| } | ||
| }, | ||
| "providesContext": { |
There was a problem hiding this comment.
shimotmk
commented
Aug 30, 2023
| * | ||
| * @param {Object} attributes The block's attributes. | ||
| */ | ||
| export function useScopedBlockVariations(attributes) { |
There was a problem hiding this comment.
shimotmk
commented
Aug 30, 2023
| * @param {string} url The URL that could not be embedded. | ||
| * @param {Function} onReplace Function to call with the created fallback block. | ||
| */ | ||
| export function fallback(url, onReplace) { |
There was a problem hiding this comment.
shimotmk
commented
Aug 30, 2023
| * @param string $url The URL for which to build a cache key. | ||
| * @return string The cache key. | ||
| */ | ||
| public static function build_cache_key_for_url( $url ) { |
|
確認中です
|
|
@sysbird
そうですね。これはこのブロックだけ調整しても根本的な問題解決になっていないので下手に対応しないほうが良いと思います。 サンプルコード。ここをクリック。<!-- wp:columns {"style":{"spacing":{"padding":{"top":"1.5rem","right":"1.5rem","bottom":"1.5rem","left":"1.5rem"},"blockGap":{"top":"1.5rem","left":"1.5rem"}},"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} -->
<div class="wp-block-columns has-border-color" style="border-color:#0000001f;border-width:1px;border-radius:5px;padding-top:1.5rem;padding-right:1.5rem;padding-bottom:1.5rem;padding-left:1.5rem"><!-- wp:column {"verticalAlignment":"top","width":"33.3%"} -->
<div class="wp-block-column is-vertically-aligned-top" style="flex-basis:33.3%"><!-- wp:image {"align":"center","sizeSlug":"large","linkDestination":"custom","style":{"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} -->
<figure class="wp-block-image aligncenter size-large has-custom-border"><a href="https://www.vektor-inc.co.jp/wp-content/uploads/2020/04/vecktor-inc_ogp2020.png"><img src="https://www.vektor-inc.co.jp/wp-content/uploads/2020/04/vecktor-inc_ogp2020.png" alt="" class="has-border-color" style="border-color:#0000001f;border-width:1px;border-radius:5px"/></a></figure>
<!-- /wp:image --></div>
<!-- /wp:column -->
<!-- wp:column {"width":"66.6%"} -->
<div class="wp-block-column" style="flex-basis:66.6%"><!-- wp:heading {"level":5} -->
<h5 class="wp-block-heading"><a href="https://www.vektor-inc.co.jp/">株式会社ベクトル | WordPressテーマ・プラグイン開発のクリエイティブカンパニー</a></h5>
<!-- /wp:heading -->
<!-- wp:paragraph -->
<p>抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル抜粋サンプル粋抜</p>
<!-- /wp:paragraph -->
<!-- wp:group {"style":{"spacing":{"blockGap":"6px"}},"layout":{"type":"flex","flexWrap":"nowrap","verticalAlignment":"center"}} -->
<div class="wp-block-group"><!-- wp:image {"sizeSlug":"large","style":{"layout":{"selfStretch":"fixed","flexSize":"15px"}}} -->
<figure class="wp-block-image size-large"><img src="https://www.vektor-inc.co.jp/wp-content/uploads/2020/03/cropped-icon2020-32x32.png" alt=""/></figure>
<!-- /wp:image -->
<!-- wp:paragraph -->
<p><a href="https://www.vektor-inc.co.jp/">株式会社ベクトル</a></p>
<!-- /wp:paragraph --></div>
<!-- /wp:group --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->
<!-- wp:columns {"style":{"spacing":{"padding":{"top":"1.5rem","right":"1.5rem","bottom":"1.5rem","left":"1.5rem"},"blockGap":{"top":"1.5rem","left":"1.5rem"}},"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} -->
<div class="wp-block-columns has-border-color" style="border-color:#0000001f;border-width:1px;border-radius:5px;padding-top:1.5rem;padding-right:1.5rem;padding-bottom:1.5rem;padding-left:1.5rem"><!-- wp:column {"verticalAlignment":"top","width":"33.3%"} -->
<div class="wp-block-column is-vertically-aligned-top" style="flex-basis:33.3%"><!-- wp:post-featured-image {"style":{"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} /--></div>
<!-- /wp:column -->
<!-- wp:column {"width":"66.6%"} -->
<div class="wp-block-column" style="flex-basis:66.6%"><!-- wp:post-title {"level":5} /-->
<!-- wp:post-excerpt /-->
<!-- wp:group {"style":{"spacing":{"blockGap":"6px"}},"layout":{"type":"flex","flexWrap":"nowrap","verticalAlignment":"center"}} -->
<div class="wp-block-group"><!-- wp:site-logo {"width":20} /-->
<!-- wp:site-title {"level":0} /--></div>
<!-- /wp:group --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->
<!-- wp:vk-blocks/blog-card {"url":"https://www.vektor-inc.co.jp/","style":{"spacing":{"padding":{"top":"1.5rem","right":"1.5rem","bottom":"1.5rem","left":"1.5rem"}},"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} -->
<div class="wp-block-vk-blocks-blog-card has-border-color" style="border-color:#0000001f;border-width:1px;border-radius:5px;padding-top:1.5rem;padding-right:1.5rem;padding-bottom:1.5rem;padding-left:1.5rem"><!-- wp:columns {"lock":{"move":false,"remove":true},"style":{"spacing":{"blockGap":{"top":"1.5rem","left":"1.5rem"}}}} -->
<div class="wp-block-columns"><!-- wp:column {"verticalAlignment":"top","width":"33.3%"} -->
<div class="wp-block-column is-vertically-aligned-top" style="flex-basis:33.3%"><!-- wp:vk-blocks/blog-card-featured-image {"style":{"border":{"color":"#0000001f","width":"1px","radius":"5px"}}} /--></div>
<!-- /wp:column -->
<!-- wp:column {"width":"66.6%","lock":{"move":false,"remove":true}} -->
<div class="wp-block-column" style="flex-basis:66.6%"><!-- wp:vk-blocks/blog-card-title /-->
<!-- wp:vk-blocks/blog-card-excerpt /-->
<!-- wp:group {"style":{"spacing":{"blockGap":"6px"}},"layout":{"type":"flex","flexWrap":"nowrap","verticalAlignment":"center"}} -->
<div class="wp-block-group"><!-- wp:vk-blocks/blog-card-site-logo {"style":{"layout":{"selfStretch":"fixed","flexSize":"15px"}}} /-->
<!-- wp:vk-blocks/blog-card-site-title /--></div>
<!-- /wp:group --></div>
<!-- /wp:column --></div>
<!-- /wp:columns --></div>
<!-- /wp:vk-blocks/blog-card -->
確かに、ブロックアイコンは左画像なので配置を変えておきました！
自分も詳しくはわかりませんでした。 |
sysbird
approved these changes
Sep 1, 2023
|
@shimotmk サイトタイトルのマージンは承知しました 「新しいタブで開く」設定ありました〜 ここまで動作問題ないと思いますので、どなたか2人目ご確認をお願いします |
osmdik
approved these changes
Sep 4, 2023
This was referenced Sep 4, 2023
Merged
This was referenced Oct 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由（元のissueがあればリンクを貼り付ければOK）
#749
どういう変更をしたか？
実装方法はコアのqueryブロックとembedブロックの融合みたいな感じです。
https://github.com/WordPress/gutenberg/tree/abfe3c6013bb811a0f5bf9d61a62c709c81c80c3/packages/block-library/src/query
https://github.com/WordPress/gutenberg/tree/2653b5e4f29c703a7ea52ebdc62dc254e4dc1dae/packages/block-library/src/embed
Blog Cardブロックの中のブロックも基本的にはコアブロックをベースに作っています。
・Blog Card Excerpt
https://github.com/WordPress/gutenberg/tree/259c8e7f2f94dfbe8957e3053841e4ecb083ec80/packages/block-library/src/post-excerpt
・Blog Card Featured Image
https://github.com/WordPress/gutenberg/tree/4f6d1b39350f31e242a573da64dea93175beaa74/packages/block-library/src/post-featured-image
・Blog Card Site Logo
https://github.com/WordPress/gutenberg/tree/12f305ece929393fc246544b03f7881e8a0923a1/packages/block-library/src/site-logo
・Blog Card Site Title
https://github.com/WordPress/gutenberg/tree/5ba748472b3e481e89ec3ac4c4e215031cc1eb3c/packages/block-library/src/site-title
・Blog Card Title
https://github.com/WordPress/gutenberg/tree/fec05ee8451ee1a8da43cdbf00485736e2b0a16a/packages/block-library/src/post-title
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
変更内容について何を確認したか、どういう方法で確認をしたかなど
実装者が確認した手順を箇条書きで記載してください。
確認URL
（ どこかのデモサイトかテストサーバーにデプロイ済みなどで確認できる場合はそのURL ）
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
レビュワーがどういう手順で何を確認して欲しいかを記載してください。
・適当な投稿
・埋め込み可能な外部リンク
https://vektor-inc.co.jp
・埋め込み不可能な外部リンク
https://github.com/vektor-inc/vk-blocks-pro/blob/master/vk-blocks.php
レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。