Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Node.js harness #178

Closed
wants to merge 3 commits into from

Conversation

StevenACoffman
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.171% when pulling 4369543 on vvakame:update-validations into 2776c98 on vektah:master.

@vvakame
Copy link
Collaborator

vvakame commented Feb 1, 2022

@StevenACoffman sorry for bother you. I'll try to update this harness.

@vvakame
Copy link
Collaborator

vvakame commented Feb 1, 2022

I reimplemented and re-output the spec.
But gqlparser doesn't seem to have enough implementation yet. e.g. interface Canine implements Mammal ...

@StevenACoffman
Copy link
Collaborator Author

@Code-Hex You said that this change is required for #180 but I haven't merged it because of the test failure, as we use this for regression testing.

This could be resolved either by temporarily skipping that particular unimplemented feature or by implementing that feature.

@Code-Hex
Copy link
Contributor

@StevenACoffman Yes. I think it's a necessary part of the process. because according @vvakame mentioned

But gqlparser doesn't seem to have enough implementation yet. e.g. interface Canine implements Mammal ...

#180 does support interface Canine implements Mammal case

@StevenACoffman
Copy link
Collaborator Author

So even after merging #169 and rebasing this as in #181 the tests continue to fail. I wasn't able to push the rebased version back up to @vvakame fork, so I created #181 PR to demonstrate the continued failure.

Unfortunately, I'm not going to be able to spend more time looking into this at present, so if anyone else can sort it out, I would welcome a PR that passed the tests.

@StevenACoffman
Copy link
Collaborator Author

superceded by #181 which is now merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants