Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'move' cursor added over brush mark #9164

Merged
merged 50 commits into from
Jan 30, 2024
Merged

feat: 'move' cursor added over brush mark #9164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
9792f78
vega typings version changed
alliefeldman Aug 7, 2023
af74e8a
first commit in a while
alliefeldman Sep 12, 2023
433d0b3
Merge branch 'touch-to-pointer-events' of github.com:alliefeldman/veg…
alliefeldman Sep 12, 2023
a4d59e4
done?
alliefeldman Sep 12, 2023
92edda7
final commit of this branch
alliefeldman Sep 15, 2023
70bd982
initial exploration
alliefeldman Sep 20, 2023
103237e
Merge branch 'main' of github.com:alliefeldman/vega-lite into grip-ha…
alliefeldman Sep 20, 2023
e83e043
yarn.lock
alliefeldman Sep 20, 2023
7156ffc
Merge branch 'main' of github.com:alliefeldman/vega-lite into grip-ha…
alliefeldman Sep 20, 2023
990d0d0
progress
alliefeldman Sep 21, 2023
99797b4
'move' cursor over interval mark
alliefeldman Oct 6, 2023
4d2187e
'move' cursor over brushes
alliefeldman Oct 9, 2023
532a5dc
chore(deps): bump get-func-name from 2.0.0 to 2.0.2 (#9110)
dependabot[bot] Sep 28, 2023
1572fda
fix: correct the formula for interpolating between bin start and end …
kanitw Sep 29, 2023
878b65d
chore(deps-dev): bump jest-dev-server from 9.0.0 to 9.0.1 (#9117)
dependabot[bot] Oct 1, 2023
e4ef032
chore(deps-dev): bump @babel/core from 7.22.20 to 7.23.0 (#9115)
dependabot[bot] Oct 1, 2023
a5bf191
chore(deps-dev): bump terser from 5.19.4 to 5.20.0 (#9114)
dependabot[bot] Oct 1, 2023
9109f79
docs: remove blocks link from home page (#9118)
domoritz Oct 2, 2023
7a43927
docs: link to Vega project about page (#9119)
domoritz Oct 2, 2023
2d35461
chore: release v5.15.1
kanitw Oct 2, 2023
6f9a755
chore: update gems (#9122)
domoritz Oct 3, 2023
85cd044
swap examples back to originals
alliefeldman Oct 11, 2023
e15a408
merge
alliefeldman Oct 11, 2023
301b3cc
Merge branch 'vega:main' into grip-handles
alliefeldman Oct 15, 2023
d0dd822
fetch
alliefeldman Oct 15, 2023
ee5e9f2
Merge branch 'vega:main' into grip-handles
alliefeldman Oct 29, 2023
18ac9e3
Merge branch 'vega:main' into grip-handles
alliefeldman Nov 2, 2023
43666eb
main changes
alliefeldman Nov 2, 2023
75841ce
Merge branch 'grip-handles'
alliefeldman Nov 2, 2023
f5a2473
selection
alliefeldman Nov 2, 2023
ffdcdb4
interval test update
alliefeldman Nov 2, 2023
a667fbb
slowly formatting examples back to original
alliefeldman Nov 2, 2023
43a83df
more examples formatting reverted
alliefeldman Nov 2, 2023
99f5e65
more reverted changes
alliefeldman Nov 2, 2023
41d163c
chore: update schema [CI]
Nov 2, 2023
f45b37f
chore: update examples [CI]
Nov 2, 2023
6fee7fb
style: auto-formatting [CI]
Nov 2, 2023
d1be92d
more reverted changes
alliefeldman Nov 2, 2023
bdc0d3c
Merge branch 'brush-cursor' of github.com:alliefeldman/vega-lite into…
alliefeldman Nov 2, 2023
1340766
6:41
alliefeldman Nov 2, 2023
bbf1cd4
6:48
alliefeldman Nov 2, 2023
fc24d3f
6:50
alliefeldman Nov 2, 2023
88ae773
6:51
alliefeldman Nov 2, 2023
1c9b06b
final changes
alliefeldman Nov 2, 2023
fcecc42
chore: update examples [CI]
Nov 2, 2023
f0c7695
Merge branch 'vega:main' into brush-cursor
alliefeldman Dec 13, 2023
2467935
add null edge case and requested test cases
alliefeldman Dec 16, 2023
6c7e3d3
updated examples
alliefeldman Dec 16, 2023
bec1bd7
style: fix format
domoritz Jan 30, 2024
965e62e
move cursor logic into mark builder and simplify unit tests
domoritz Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/compiled/bar_count_minimap.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/brush_table.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/dynamic_color_legend.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_1d_geo_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_airport_crossfilter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_area_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_bin_extent.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_bin_extent_bottom.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
15 changes: 12 additions & 3 deletions examples/compiled/interactive_crossfilter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -701,7 +704,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -1007,7 +1013,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
15 changes: 12 additions & 3 deletions examples/compiled/interactive_dashboard_europe_pop.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -959,7 +962,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -1360,7 +1366,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
15 changes: 12 additions & 3 deletions examples/compiled/interactive_layered_crossfilter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -845,7 +848,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down Expand Up @@ -1206,7 +1212,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_overview_detail.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_paintbrush_interval.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/interactive_seattle_weather.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
45 changes: 36 additions & 9 deletions examples/compiled/interactive_splom.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down Expand Up @@ -1073,7 +1076,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down Expand Up @@ -1493,7 +1499,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"value": 0},
Expand Down Expand Up @@ -2002,7 +2011,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down Expand Up @@ -2424,7 +2436,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"value": 0},
Expand Down Expand Up @@ -2929,7 +2944,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down Expand Up @@ -3353,7 +3371,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"value": 0},
Expand Down Expand Up @@ -3862,7 +3883,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down Expand Up @@ -4374,7 +4398,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": {"signal": "brush_x[0]"},
"y": {"signal": "brush_y[0]"},
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/isotype_grid.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/selection_brush_timeunit.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
5 changes: 4 additions & 1 deletion examples/compiled/selection_clear_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,10 @@
"type": "rect",
"clip": true,
"encode": {
"enter": {"fill": {"value": "transparent"}},
"enter": {
"cursor": {"value": "move"},
"fill": {"value": "transparent"}
},
"update": {
"x": [
{
Expand Down
Loading
Loading