feat: make bar & rect marks support bandPosition (allow center-align bars and ticks) #9126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/timeUnit-bar-bandPosition
branch
from
5e5a4c3 to
f22bd4c
Compare
kanitw
force-pushed
the
kw/timeUnit-bar-bandPosition
branch
from
2d794ea to
b4827b6
Compare
kanitw
changed the title
kanitw
force-pushed
the
kw/timeUnit-bar-bandPosition
branch
from
b4827b6 to
123c428
Compare
kanitw
force-pushed
the
kw/timeUnit-bar-bandPosition
branch
from
123c428 to
3d5110e
Compare
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…ent with ticks) (vega#9126) * docs(examples): examples for using bandPosition=0 * chore: update examples [CI] * fix: calculate offseted rect position for timeUnit if bandPosition != 0.5 * fix: use offsetted rect position in aggregate * fix: use offsetted rect in mark position * fix: use offsetted rect in scale domain * fix: correctly read default bandPosition * fix: apply bandOffset to grouped bars with timeUnit * chore: update examples [CI] * style: auto-formatting [CI] * docs: update docs * chore: update TOC [CI] --------- Co-authored-by: GitHub Actions Bot <[email protected]>
alliefeldman
pushed a commit
to alliefeldman/vega-lite
that referenced
this pull request
Nov 2, 2023
…ent with ticks) (vega#9126) * docs(examples): examples for using bandPosition=0 * chore: update examples [CI] * fix: calculate offseted rect position for timeUnit if bandPosition != 0.5 * fix: use offsetted rect position in aggregate * fix: use offsetted rect in mark position * fix: use offsetted rect in scale domain * fix: correctly read default bandPosition * fix: apply bandOffset to grouped bars with timeUnit * chore: update examples [CI] * style: auto-formatting [CI] * docs: update docs * chore: update TOC [CI] --------- Co-authored-by: GitHub Actions Bot <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: make bar & rect marks support bandPosition (allow center-align bars and ticks)!
(Address concerns discussed in #9025.)
Example: (left = old style, right = center align bar and ticks)
This also works for grouped bars