Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frame animations with time encoding and timer param #8921

Merged
merged 72 commits into from
Nov 14, 2024

Conversation

jonathanzong
Copy link
Member

@jonathanzong jonathanzong commented May 25, 2023

This change implements basic features of Animated Vega-Lite. With this change, users can create frame animations using a time encoding, a timer point selection, and a filter transform.

This change does not include more complex features e.g.: interpolation, custom predicates, rescale, interactive sliders, or data-driven pausing.

  • Adds a time encoding channel
  • Adds isTimerSelection function to check if a selection is an animation selections
  • Builds _curr animation dataset for timer selections to store the current animation frame
  • Adds animation signals to track the elapsed time (anim_clock), current animation value (anim_value), current position in the animation field's domain (t_index), etc.
  • When time encoding is present, updates associated marks' from.data to use the animation dataset (current frame).

Relevant issue: #4060

Coauthor: @joshpoll

Example specs

Hop example:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {
    "url": "data/seattle-weather.csv"
  },
  "mark": "tick",
  "config": {
    "tick": {
      "thickness": 3
    }
  },
  "params": [
    {
      "name": "date",
      "select": {
        "type": "point",
        "fields": [
          "date"
        ],
        "on": "timer"
      }
    }
  ],
  "transform": [
    {
      "filter": {
        "param": "date"
      }
    }
  ],
  "encoding": {
    "y": {
      "field": "precipitation",
      "type": "quantitative"
    },
    "time": {
      "field": "date"
    }
  }
}

Gapminder:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {
    "url": "data/gapminder.json"
  },
  "mark": "point",
  "params": [
    {
      "name": "avl",
      "select": {
        "type": "point",
        "fields": [
          "year"
        ],
        "on": "timer"
      }
    }
  ],
  "transform": [
    {
      "filter": {
        "param": "avl"
      }
    }
  ],
  "encoding": {
    "color": {
      "field": "country"
    },
    "x": {
      "field": "fertility",
      "type": "quantitative"
    },
    "y": {
      "field": "life_expect",
      "type": "quantitative"
    },
    "time": {
      "field": "year"
    }
  }
}

@jonathanzong jonathanzong marked this pull request as ready for review May 25, 2023 22:17
@jonathanzong
Copy link
Member Author

@domoritz @arvind this is ready for review. we were thinking hold off on docs and examples until a later PR, but let us know if you'd rather us include it here

@domoritz
Copy link
Member

Thanks. Can we see whether you can run the formatting action as well so we know the formatting doesn't break.

@jonathanzong
Copy link
Member Author

i was able to run yarn format with no problems, we've been using the eslint config

@domoritz
Copy link
Member

Great. I was hoping we could get the GitHub action for checking formatting to work somehow.

@joshpoll
Copy link
Contributor

I think it's running in the Runtime, Linting, and Coverage test.

Screen Shot 2023-05-30 at 10 48 44 AM

src/compile/scale/range.ts Outdated Show resolved Hide resolved
src/compile/unit.ts Outdated Show resolved Hide resolved
Copy link
Member

@arvind arvind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, y'all! A great start. I've left line-level comments throughout and will do a more holistic review next. In the meantime, some higher-level thoughts:

  • Thanks for including example specs in your PR OP. Could you include them as json specs under examples as well please? That'll slurp them into our CI process (and, I think?, make them easier to expose in the documentation)
  • It might behoove us to also include some runtime tests since they've saved our (namely, my) behind a number of times when the compile-time specs appeared to be correctly constructed? (I'm happy to walk through the runtime test infrastructure post-CHI since it's a little complicated).

@domoritz domoritz changed the title [Animated Vega-Lite] frame animations with time encoding and timer param feat: frame animations with time encoding and timer param Sep 19, 2023
@jonathanzong
Copy link
Member Author

first round of comments has been addressed. pending todos:

@jonathanzong jonathanzong requested a review from a team as a code owner January 22, 2024 21:29
@mattijn
Copy link
Contributor

mattijn commented Apr 6, 2024

c72cb7d was an attempt to trigger the deployment preview of #9294..

@mattijn
Copy link
Contributor

mattijn commented Apr 7, 2024

Hi @jonathanzong and @joshpoll!👋 Would you mind updating this PR so the latest changes from the main repository are also included in this branch?

Im not brave enough to do it myself🙈, but I'm sensing that this is the reason why the new deployment preview is not yet triggering.

@mattijn
Copy link
Contributor

mattijn commented Apr 7, 2024

Just thinking about making a map with the trajectory of the upcoming eclipse🥳

@joelostblom
Copy link
Contributor

Just thinking about making a map with the trajectory of the upcoming eclipse🥳

Such a cool idea! Please share if you create it, I would love to see an animated VL chart for this.

Btw, @jonathanzong are you waiting for a review on this branch or are you planning to add more commits (I saw you were still adding more since you last requested a review).

@joshpoll
Copy link
Contributor

joshpoll commented Apr 8, 2024

I rebased

@jonathanzong
Copy link
Member Author

We are indeed just waiting for a review

@arvind
Copy link
Member

arvind commented Apr 8, 2024

Yes, apologies, it's been on my docket for a while but I've been underwater with various other deadlines. My plan is to wrap this up this month 🤞

@jonathanzong
Copy link
Member Author

jonathanzong commented Oct 29, 2024

i have rebased, fixed checks, and verified that the animation works as expected in local editor

edit: i'm going to wait to fix the codecov until after we get a review because otherwise we'll just have to do it again

"mark": "point",
"params": [
{
"name": "avl",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point but it'd be great to name this in a more semantically-meaningful way vs (what I assume) is an abbreviation of "Animated Vega-Lite".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/compile/selection/point.ts Show resolved Hide resolved
src/compile/selection/point.ts Show resolved Hide resolved
@jonathanzong
Copy link
Member Author

jonathanzong commented Oct 31, 2024

i have added an error explaining that facet, layer, and concat animations are unsupported when a user tries to create them (and unit tests for this error).

how serious are we about codecov? if you look at what's left, it's codecov asking for:

  • unit test for consts that i added
  • unit tests for one-line util functions for the runtime tests
  • one-line cleanup changes i made to existing logs that previously apparently also did not have coverage

can we just bypass this?

Copy link
Member

@arvind arvind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

I think we're good to go here. And I agree, fine to bypass the codecov—it seems to be failing on exceedingly minor things.

@arvind arvind merged commit e3f9620 into vega:main Nov 14, 2024
6 of 8 checks passed
domoritz added a commit that referenced this pull request Nov 18, 2024
Follow up from #8921

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
domoritz added a commit that referenced this pull request Dec 4, 2024
@jonathanzong @arvind this was missing from
#8921

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants