Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#8338,#8126): make boxplot work with single value per group #8339

Merged
merged 8 commits into from
Apr 8, 2024
Merged

fix(#8338,#8126): make boxplot work with single value per group #8339

merged 8 commits into from
Apr 8, 2024

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Aug 4, 2022 •
edited by domoritz
Loading

Fixes #8338, fixes #8126

@kanitw kanitw force-pushed the kw/8338-boxplot-single-value branch from 68e9e44 to 18510b9 Compare August 4, 2022 15:30
@kanitw kanitw force-pushed the kw/8338-boxplot-single-value branch from 32680d2 to 6632926 Compare October 5, 2023 04:58
@kanitw kanitw changed the base branch from next to main October 5, 2023 05:02
@kanitw kanitw force-pushed the kw/8338-boxplot-single-value branch from 2c0213e to f30c358 Compare April 5, 2024 12:51
@kanitw kanitw marked this pull request as ready for review April 5, 2024 12:52
@kanitw kanitw requested a review from a team as a code owner April 5, 2024 12:52
@kanitw kanitw requested review from lsh and fandu-db April 5, 2024 12:52
@kanitw
Copy link
Member Author

kanitw commented Apr 5, 2024

It's working now!

image

@domoritz
Copy link
Member

domoritz commented Apr 5, 2024 •
edited
Loading

Nice. Should we merge then?

@joelostblom
Copy link
Contributor

joelostblom commented Apr 5, 2024 •
edited
Loading

I think @kanitw meant it is working on this branch? And that the PR is ready for review.

Btw, @kanitw would this also fix #8126

@kanitw
Copy link
Member Author

kanitw commented Apr 5, 2024

Yep, I think so, it should fix #8126 too.

@kanitw
Copy link
Member Author

kanitw commented Apr 5, 2024

image

@kanitw kanitw changed the title fix(#8338): make boxplot work with single value per group fix(#8338,#8126): make boxplot work with single value per group Apr 6, 2024
fandu-db
fandu-db approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@fandu-db fandu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Get it in!!!

@kanitw kanitw merged commit 4e55836 into main Apr 8, 2024
11 checks passed
@kanitw kanitw deleted the kw/8338-boxplot-single-value branch April 8, 2024 17:20
@joelostblom
Copy link
Contributor

This is great, thank you @kanitw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fandu-db fandu-db fandu-db approved these changes

@lsh lsh Awaiting requested review from lsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kanitw @domoritz @joelostblom @fandu-db