-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make setting axis
or legend
= null
as the default way to disable them.
#1384
Conversation
|
|
|
|
0b68dae
to
7e7ad77
Compare
Haven't tested since I don't have TS 2.0 locally yet!
How will nullable be expressed in the scheme? In wrapper languages we'll need to handle this case explicitly (since not all types can be null, so will need to do something funky). Json schema has "required" but that really means undefinable, and is already being used for that purpose. And in general in JavaScript is it ok to have null != undefined? I don't know since I'm not a JS guy, but in typed languages there's really no equivalent to this, so having them mean something different will be tricky to support (for example in the Json parser I'm using it assume they're equivalent). |
@aishfenton We explicitly mark properties that can be |
Remove the support for
axis: false
and just supportaxis: null
and simplify the schemaas briefly discussed in #1377.