'Duplicate signal name' error for shared param across views #6890

cjnygard · 2020-09-22T03:50:02Z

When using repeat to layer multiple fields, one is unable to use hover to implement any interaction. An error is shown Error: Duplicate signal name: "sel1_tuple"

See https://observablehq.com/@cjnygard/vega-lite-bug for implementation (you can play with the flags in the plot4() function to true different combinations of hover, repeat, and facet. It's clearly related to the repeat, as shown in the below generated JSON (generated from the page above).

{
  "facet": {
    "column": {
      "field": "name"
    }
  },
  "spec": {
    "repeat": {
      "layer": [
//        "y1",    // Uncomment this to trigger bug
        "y2"
      ]
    },
    "spec": {
      "layer": [
        {
          "mark": {
            "type": "line",
            "interpolate": "monotone"
          },
          "encoding": {
            "x": {
              "field": "x",
              "type": "quantitative"
            },
            "y": {
              "field": {
                "repeat": "layer"
              },
              "type": "quantitative"
            },
            "color": {
              "datum": {
                "repeat": "layer"
              },
              "legend": {
                "title": "Legend"
              }
            }
          }
        },
        {
          "mark": {
            "type": "circle"
          },
          "encoding": {
            "x": {
              "field": "x",
              "type": "quantitative"
            },
            "y": {
              "field": {
                "repeat": "layer"
              },
              "type": "quantitative"
            },
            "color": {
              "datum": {
                "repeat": "layer"
              },
              "legend": {
                "title": "Legend"
              }
            },
            "opacity": {
              "condition": {
                "test": {
                  "selection": "sel1"
                },
                "value": 1
              },
              "value": 0
            }
          },
          "selection": {
            "sel1": {
              "type": "single",
              "encodings": [
                "y"
              ],
              "on": "mouseover",
              "nearest": true,
              "empty": "none"
            }
          }
        }
      ],
      "width": 350,
      "height": 200
    }
  },
  "data": {
    "values": [
      {
        "name": "foo",
        "x": 1,
        "y1": 1,
        "y2": 21
      },
      {
        "name": "foo",
        "x": 2,
        "y1": 2,
        "y2": 22
      },
      {
        "name": "foo",
        "x": 3,
        "y1": 3,
        "y2": 23
      },
      {
        "name": "bar",
        "x": 4,
        "y1": 10,
        "y2": 31
      },
      {
        "name": "bar",
        "x": 5,
        "y1": 11,
        "y2": 32
      },
      {
        "name": "bar",
        "x": 6,
        "y1": 12,
        "y2": 33
      }
    ]
  }
}

The text was updated successfully, but these errors were encountered:

domoritz · 2020-09-22T05:17:32Z

Thanks for the bug report. To isolate the issue, can you try to simplify the spec to a minimal spec?

cjnygard · 2020-09-25T02:12:42Z

It already is. Uncomment the line, it will break. Comment the line, it will not break. It has two lines, each with three points, so that you can see the hover in action reliably. It has one x coord, and two y coords, so you can actually see the difference when repeating for two fields. See the Observablehq page linked above if you want to play with layer/facet/repeat options.

domoritz · 2020-09-25T03:47:21Z

Could you do me a favor and try to reproduce the issue with just layer and no repeat? It would help us isolate the problem.

cjnygard · 2020-09-28T03:59:31Z

I cannot. It works fine without repeat.

{
  "facet": {
    "column": {
      "field": "name"
    }
  },
  "spec": {
    "layer": [
      {
        "mark": {
          "type": "line",
          "interpolate": "monotone"
        },
        "encoding": {
          "x": {
            "field": "x",
            "type": "quantitative"
          },
          "y": {
            "field": "y1",
            "type": "quantitative"
          },
          "color": {
            "datum": "y1",
            "legend": {
              "title": "Legend"
            }
          }
        }
      },
      {
        "mark": {
          "type": "circle"
        },
        "encoding": {
          "x": {
            "field": "x",
            "type": "quantitative"
          },
          "y": {
            "field": "y1",
            "type": "quantitative"
          },
          "color": {
            "datum": "y1",
            "legend": {
              "title": "Legend"
            }
          },
          "opacity": {
            "condition": {
              "test": {
                "selection": "sel1"
              },
              "value": 1
            },
            "value": 0
          }
        },
        "selection": {
          "sel1": {
            "type": "single",
            "encodings": [
              "y"
            ],
            "on": "mouseover",
            "nearest": true,
            "empty": "none"
          }
        }
      }
    ],
    "width": 350,
    "height": 200
  },
  "data": {
    "values": [
      {
        "name": "foo",
        "x": 1,
        "y1": 1,
        "y2": 21
      },
      {
        "name": "foo",
        "x": 2,
        "y1": 2,
        "y2": 22
      },
      {
        "name": "foo",
        "x": 3,
        "y1": 3,
        "y2": 23
      },
      {
        "name": "bar",
        "x": 4,
        "y1": 10,
        "y2": 31
      },
      {
        "name": "bar",
        "x": 5,
        "y1": 11,
        "y2": 32
      },
      {
        "name": "bar",
        "x": 6,
        "y1": 12,
        "y2": 33
      }
    ]
  }
}

wmarques · 2021-01-08T17:11:44Z

Hello, do you have any solution to this issue ? I'm trying to have a tooltip like this while using the repeat feature but if I put the rule layer inside the spec I have the same error.
I also tried to put the rule layer on top level of the object in the layer property but it seems ignored if I use the repeat feature...

If you have any hint that would be appreciated 😄 thanks !

domoritz · 2021-01-08T17:24:54Z

I haven't looked into this issue yet. To make debugging easier it would be awesome if you could create a minimal example.

kanitw · 2022-03-11T19:36:53Z

I'm able to replicate this when we add params to top-level for multi-view charts

{

  "params": [{"name": "selection", "select": {"type": "point"}}],
  "data": {"url": "data/cars.json"},
  "layer": [
    {
      "mark": {"type": "point", "filled": true},
      "encoding": {
        "x": {"field": "Horsepower", "type": "quantitative"},
        "y": {"field": "Acceleration", "type": "quantitative"}
      }
    },
    {
      "transform": [{"filter": {"param": "selection"}}],
      "mark": {"type": "point", "filled": true},
      "encoding": {
        "x": {"field": "Horsepower", "type": "quantitative"},
        "y": {"field": "Acceleration", "type": "quantitative"}
      }
    }
  ]
}

jw5 · 2022-10-04T07:03:33Z

Hard to believe this bug has been open for over two years and is now a P2. As from days spent trying to work around it, it reduces both primary means of dealing with data complexity, faceting and repeats, as no longer supporting direct interaction. I guess this yields a "Graphenberg" state, you can see your data, or you can interact with it, but you can't do both :-(

mattijn · 2022-10-04T11:30:13Z

The reply from @kanitw with top-level defined params and a layered chart can be resolved using views within params in combination with a name definition on a single chart object within the layer: Open the Chart in the Vega Editor

Status of a chart with a:

✅ repeat operator & params within the spec: Open the Chart in the Vega Editor
✅ repeat operator & params top-level: Open the Chart in the Vega Editor
✅ repeat operator & params top-level using a views attribute and name: Open the Chart in the Vega Editor
✅ repeat operator on a layer & params on the first object within layer: Open the Chart in the Vega Editor (slow!)
❌ repeat operator on a layer & params top-level: Open the Chart in the Vega Editor
✅ repeat operator on a layer & params top-level using a views attribute & name on the first object within layer: Open the Chart in the Vega Editor (slow!)

The following issue is also related to the repeat operator on a layer with params top-level using a views attribute & name on the first object within layer: #8348, but there is still another issue with brush not resolving properly.

jw5 · 2022-10-07T05:17:40Z

First, thank you very much for the timely and informative answer with several examples. Alas, I've spent a day trying, but my attempts to generalize your solution and apply it to my particular charts have not met with much success. I just can't seem to get a faceted repeated layered specification to work.

Working simple facet(repeat(layer)) without interaction: Open the Chart in the Vega Editor

Broken attempt to add interaction version 1 of 10: Open the Chart in the Vega Editor

Note: These are not meant to be great graphics, just the smallest perturbation to your examples that reflected the nesting structure I need for my data (multiple factor columns and repeated metric fields).

Hopefully there is a known workaround for this version of the problem.

Thanks,
Jim

mattijn · 2022-10-07T08:51:33Z

Two things:

I was not able to render a chart with a name-defined layer (here below FOO) in combination with a repeat and facet operator (without parameters defined).

The following Vega-Lite spec, Open the Chart in the Vega Editor:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {"url": "data/weather.csv"},
  "facet": {"field": "location", "type": "nominal"},
  "spec": {
    "repeat": {"layer": ["temp_max", "precipitation", "wind"]},
    "spec": {
      "layer": [
        {
          "name": "FOO",
          "mark": "rule",
          "encoding": {
            "x": {"field": "date", "timeUnit": "month"},
            "color": {"value": "black"},
            "opacity": {"value": 1}
          }
        },
        {
          "mark": {"type": "line", "point": false},
          "encoding": {
            "x": {"field": "date", "timeUnit": "month"},
            "y": {"field": {"repeat": "layer"}, "aggregate": "mean"},
            "color": {"datum": {"repeat": "layer"}, "type": "nominal"}
          }
        }
      ]
    }
  }
}

Result in the following error:

Duplicate data set name: "FOO_marks".

If you remove "name": "FOO" then the chart renders, but I think you need this name to set a spefic view in the params to avoid the duplicate signal name error (?). I do not know an approach how to define or refer to a unique name, maybe using an expr?

A workaround.

You can use a fold-transform on the columns that you like to layer and use the key-value output instead of the repeat operator.

As such, Open the Chart in the Vega Editor:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {"url": "data/weather.csv"},
  "transform": [{"fold": ["temp_max", "precipitation", "wind"]}],
  "facet": {"field": "location", "type": "nominal"},
  "params": [
    {
      "name": "HIGHLIGHT",
      "select": {
        "type": "point",
        "nearest": true,
        "on": "mouseover",
        "clear": "mouseout",
        "encodings": ["x"]
      },
      "views": ["CHART_0"]
    }
  ],
  "spec": {
    "layer": [
      {
        "name": "CHART_0",
        "mark": "rule",
        "encoding": {
          "x": {"field": "date", "timeUnit": "month"},
          "color": {"value": "black"},
          "opacity": {
            "condition": {"param": "HIGHLIGHT", "empty": false, "value": 1},
            "value": 0
          }
        }
      },
      {
        "mark": {"type": "line", "point": true},
        "encoding": {
          "x": {"field": "date", "timeUnit": "month"},
          "y": {"field": "value", "aggregate": "mean", "title":"Mean of temp_max, precipitation, wind"},
          "color": {"field": "key", "type": "nominal", "title":null}
        }
      }
    ]
  }
}

And a bonus, using row/column facetting and a shared rule: Open the Chart in the Vega Editor

jw5 · 2022-10-07T17:39:28Z

I tried several variations to solve 1. Direct use of expr, field etc result in duplicate object... That suggests that the duplication occurs before evaluation. So then I tried moving it under evaluation. That doesn't fail directly, it parses and executes to no effect, which suggests the mapping to the signal is broken.

Open the Chart in the Vega Editor

While the conversion from wide to long form (R GGplot vernacular) works well for smaller data sets. I'm pushing 100K+ records with perhaps 5-10 dimensions and 10+ metrics. My concern is that doing a fold transform will increase the record count 10X and carry lots of duplicate dimension information thus resulting in increased memory requirements in the browser. Still, it may be a performance hit I'll have to take for more complex charts.

Thanks,
Jim

mattijn · 2022-10-07T19:36:30Z

I also tried encoding name. Its intuitive, but it is not in the list of https://vega.github.io/vega-lite/docs/encoding.html, so probably silently ignored (cc @domoritz).
Yes, with that datasize please aggregate before rendering. We have good experiences with duckdb in combination with vega-lite.

jw5 · 2022-10-07T20:44:46Z

1) I tried unsuccessfully to locate the explicit definition of "name" by searching the vega-lite site. It is listed in the parameter definition, but I don't recall seeing it elsewhere? 2) That is the significantly aggregated data set, it starts at O(2T) records ;-) Thanks, Jim

…

On Fri, Oct 7, 2022 at 12:36 PM Mattijn van Hoek ***@***.***> wrote: 1. I also tried encoding name. Its intuitive, but it is not in the list of https://vega.github.io/vega-lite/docs/encoding.html, so probably silently ignored (cc @domoritz <https://github.com/domoritz>). 2. Yes, with that datasize please aggregate before rendering. We have good experiences with duckdb in combination with vega-lite. — Reply to this email directly, view it on GitHub <#6890 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4LRFH44URNGTL3F3VOEOLWCB3UVANCNFSM4RVI7XHQ> . You are receiving this because you commented.Message ID: ***@***.***>

aaroncsolomon · 2023-03-13T01:13:48Z

bump

cjnygard added the Bug 🐛 label Sep 22, 2020

kanitw changed the title ~~Using hover with repeat causes 'Duplicate signal name' error~~ 'Duplicate signal name' error for shared param across views Mar 11, 2022

kanitw added the P1 Critical -- to fix ASAP label Mar 11, 2022

kanitw self-assigned this Mar 11, 2022

kanitw added P2 Important Issues that should be fixed soon and removed P1 Critical -- to fix ASAP labels Mar 11, 2022

mattijn mentioned this issue Oct 4, 2022

WIP: Lifting parameters to the top level vega/altair#2684

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'Duplicate signal name' error for shared param across views #6890

'Duplicate signal name' error for shared param across views #6890

cjnygard commented Sep 22, 2020

domoritz commented Sep 22, 2020

cjnygard commented Sep 25, 2020 •

edited

Loading

domoritz commented Sep 25, 2020

cjnygard commented Sep 28, 2020

wmarques commented Jan 8, 2021

domoritz commented Jan 8, 2021

kanitw commented Mar 11, 2022

jw5 commented Oct 4, 2022

mattijn commented Oct 4, 2022 •

edited

Loading

jw5 commented Oct 7, 2022

mattijn commented Oct 7, 2022 •

edited

Loading

jw5 commented Oct 7, 2022

mattijn commented Oct 7, 2022

jw5 commented Oct 7, 2022 via email

aaroncsolomon commented Mar 13, 2023

'Duplicate signal name' error for shared param across views #6890

'Duplicate signal name' error for shared param across views #6890

Comments

cjnygard commented Sep 22, 2020

domoritz commented Sep 22, 2020

cjnygard commented Sep 25, 2020 • edited Loading

domoritz commented Sep 25, 2020

cjnygard commented Sep 28, 2020

wmarques commented Jan 8, 2021

domoritz commented Jan 8, 2021

kanitw commented Mar 11, 2022

jw5 commented Oct 4, 2022

mattijn commented Oct 4, 2022 • edited Loading

jw5 commented Oct 7, 2022

mattijn commented Oct 7, 2022 • edited Loading

jw5 commented Oct 7, 2022

mattijn commented Oct 7, 2022

jw5 commented Oct 7, 2022 via email

aaroncsolomon commented Mar 13, 2023

cjnygard commented Sep 25, 2020 •

edited

Loading

mattijn commented Oct 4, 2022 •

edited

Loading

mattijn commented Oct 7, 2022 •

edited

Loading