Set stack for area with plain Qs on the both axes

vega · Jul 19, 2023 · 5b8ee24 · 5b8ee24
1 parent 277e556
commit 5b8ee24
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/examples/specs/area_cumulative_freq.vl.json b/examples/specs/area_cumulative_freq.vl.json
@@ -14,7 +14,8 @@
     },
     "y": {
       "field": "Cumulative Count",
-      "type": "quantitative"
+      "type": "quantitative",
+      "aggregate": "max"
     }
   }
 }
diff --git a/src/stack.ts b/src/stack.ts
@@ -106,7 +106,7 @@ function potentialStackedChannel(
         return xAggregate ? x : y;
       }
 
-      if (isCartesian && mark === 'bar') {
+      if (isCartesian && ['bar', 'area'].includes(mark)) {
         if (orient === 'vertical') {
           return y;
         } else if (orient === 'horizontal') {

diff --git a/test/stack.test.ts b/test/stack.test.ts
@@ -327,6 +327,21 @@ describe('stack', () => {
       }
     });
 
+    it('should stack even for two plain quantitatives with the orient on the axes', () => {
+      for (const mark of [BAR, AREA]) {
+        const spec: TopLevel<NormalizedUnitSpec> = {
+          data: {url: 'data/movies.json'},
+          mark: {type: mark, orient: 'vertical'}, // orient also can be inferred by init.ts
+          encoding: {
+            x: {field: 'IMDB Rating', type: 'quantitative'},
+            y: {field: 'Rotten Tomatoes Rating', type: 'quantitative'}
+          }
+        };
+        const stackProps = stack(spec.mark, spec.encoding);
+        expect(stackProps.fieldChannel).toBe(Y);
+      }
+    });
+
     it('should be correct for horizontal (single)', () => {
       for (const stackableMark of [BAR, AREA]) {
         const spec: TopLevel<NormalizedUnitSpec> = {