-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up auto for versioning/release management #749
Conversation
ed579fe
to
43d69a3
Compare
544f854
to
004e482
Compare
32d8a70
to
26c50a3
Compare
7ab140c
to
797f3cf
Compare
797f3cf
to
8048813
Compare
3579e98
to
248c6ff
Compare
e59e96d
to
4a4522d
Compare
4a4522d
to
a632c0f
Compare
5617f40
to
73e34de
Compare
.github/workflows/publish.yml
Outdated
- name: Publish to NPM | ||
run: npm publish | ||
|
||
# npm config set scripts-prepend-node-path true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the comment. What this did was make sure that the version of node being used with npm
and the version used when running npm run SCRIPT_NAME
would be the same. I thought this might fix the issue (around needing 2 auth variables to be set), but it unfortunately didn't work.
env: | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I unfortunately don't know why this is different in Node 15 (which seems to be the main difference between this repo and the other 4 vega repos we've set this up for. I tested with just one or the other, and it didn't work in either case.
🚀 PR was released in |
Motivation
Changes
Testing
Pre-merge checklist for a repo admin
next
from the current head ofmaster
master
next
the base branch for the whole repostable
from the latest tagv6.18.2
https://github.com/vega/vega-embed/tree/stableskip-release
andreleased
in this repo (the first is used to tell auto not to release anything if this PR is released, the second is used to tag PRs that have been released).Debugging Notes
NPM_TOKEN
, followed by an authentication error. I tried setting justNPM_TOKEN
orNODE_AUTH_TOKEN
(which works for all the other repos), but for some reason the command fails unless you use both. Switching back to Node 14 (from the current 15) doesn't seem to make a difference.yarn run
, it quietly changes the package registry to yarnpkg instead of npmjs (as reported Running a yarn command with yarn sets registry to https://registry.yarnpkg.com yarnpkg/yarn#5854 ). After trying a few different "workarounds" and gradually increasing logging verbosity, I found the most reliable option was to removeyarn
from the release command, and usingnpm run
instead ofyarn run
for this one task.📦 Published PR as canary version:
6.18.3--canary.749.7906d39.0
✨ Test out this PR locally via: