Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename weather.json -> weekly-weather.json #650

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Dec 20, 2024

Closes #633

Description

This PR renames a dataset and updates references to it in this repo.

I've added an alert to document this, which will render like below:

image

Downstream work

The examples referenced in (#633 (comment)) will need to be updated after the major release.

@dangotbanned dangotbanned marked this pull request as ready for review December 20, 2024 12:29
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a release before merging this or include it in the next major release?

@dangotbanned
Copy link
Member Author

dangotbanned commented Dec 20, 2024

Thanks for approving @domoritz

Should we make a release before merging this or include it in the next major release?

No strong feelings from me.
I thought the plan was that the next release was a major one? (vega/vega#3990)

Edit

Maybe time the major release here to be before vega-lite & vega?

@domoritz
Copy link
Member

Yep, I was just wondering whether there is anything we want to release before a major release.

@dangotbanned
Copy link
Member Author

Yep, I was just wondering whether there is anything we want to release before a major release.

Once this and #648 are merged, we'll have no more open issues.
Maybe worth opening another one for v3 ideas (like #145)?

The only thing I've been considering was standardising date/time format strings.
So for any datasets that aren't explicitly being used to demonstrate parsing - could be transitioned to ISO 8601.

This isn't every case, but demonstrates some formats

Integer year

[{"yield":27,"variety":"Manchuria","year":1931,"site":"University Farm"},

All natural disasters,1900,1267360

{"side": "right", "year": 1957, "miles": 3706, "gas": 2.40},

"year": 1850,

{"name":"Elizabeth","start":1565,"end":1603,"index":0},

Float time

flights-200k.(arrow|json)

{"delay":-11,"distance":2419,"time":0.016666666666666666}

String date/datetime

"Year":"1970-01-01",

1958-03-01,315.70,314.44

flights-(2|5|10|20)k.json

"date":"2001/01/01 06:55",

2015/01/01 01:00:00,2

2001-01-01,Fossil Fuels,35361

Cesar A.,Aguilar,18,Male,Latino,1992-04-30,2009 W. 6th St.,Westlake,Officer-involved shooting,-118.2739756,34.0592814

movies.json

"Release Date": "Jun 12 1998"

{ "date": "2009-06-01", "open": 28.7, "high": 30.05, "low": 28.45, "close": 30.04, "signal": "short", "ret": -4.89396411092985 },

"Coverage_End_Date":"01/31/2015",

2010-01-01T01:00:00,1016.6,4.0,3.8

2012-01-01,0.0,12.8,5.0,4.7,drizzle

2000-01-03,1469.250000,1478.000000,1438.359985,1455.219971,1455.219971,931800000

Jan 1 2000,1394.46

MSFT,Jan 1 2000,39.81

unemployment-across-industries.json

{"series":"Government","year":2000,"month":1,"count":430,"rate":2.1,"date":"2000-01-01T08:00:00.000Z"},

2006-01-01,135450,113603,22467,112983,91136,656,7601,14210,8982,5228,26162,5840.4,15351.5,4420,549.8,3052,8307,17299,17946,12945,5425,21847,282

Seattle,2012-01-01,0.0,12.8,5.0,4.7,drizzle

{"year":"1565","wheat":41,"wages":5},

@domoritz
Copy link
Member

domoritz commented Dec 20, 2024

Okay,I'll just make a release with all the changes then (when I get to it). Definitely make a datasets release before the others. Feel free to merge then.

@dangotbanned dangotbanned merged commit 40ffbd4 into main Dec 20, 2024
4 checks passed
@dangotbanned dangotbanned deleted the rename-weekly-weather branch December 20, 2024 17:53
@dangotbanned dangotbanned mentioned this pull request Dec 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breaking: Rename weather.json -> weekly-weather.json
2 participants