Don't define/require under nbextension prefix (#382)

package.json

@@ -26,11 +26,19 @@
     "@types/webpack-env": "*"
   },
   "devDependencies": {
+    "filemanager-webpack-plugin": "^6.1.7",
     "prettier": "^2.5.1",
     "typescript": "^4.5.5",
     "ts-loader": "^9.2.6",
     "webpack": "^5.68.0",
     "webpack-cli": "^4.9.2"
   },
-  "private": true
+  "files": [
+    "dist",
+    "src",
+    "package.json",
+    "tsconfig.json",
+    "webpack.config.js",
+    "yarn.lock"
+  ]
 }

src/extension.js

@@ -0,0 +1,20 @@
+// This file contains the javascript that is run when the notebook is loaded.
+// It contains some requirejs configuration and the `load_ipython_extension`
+// which is required for any notebook extension.
+//
+// Some static assets may be required by the custom widget javascript. The base
+// url for the notebook is not known at build time and is therefore computed
+// dynamically.
+__webpack_public_path__ = document.querySelector('body').getAttribute('data-base-url') + 'nbextensions/jupyter-vega';
+
+
+// Configure requirejs
+if (window.require) {
+  window.require.config({
+    map: {
+      "*": {
+        "jupyter-vega": "nbextensions/jupyter-vega/index",
+      }
+    }
+  });
+}

src/index.ts

@@ -91,3 +91,5 @@ export function render(
     })
     .catch((error) => showError(el, error));
 }
+
+export * from "./widget";

src/vega.js

@@ -0,0 +1,32 @@
+const spec = {spec};
+const opt = {opt};
+const type = "{type}";
+const id = "{id}";
+
+const output_area = this;
+
+require(["jupyter-vega"], function(vega) {{
+  const target = document.createElement("div");
+  target.id = id;
+  target.className = "vega-embed";
+
+  const style = document.createElement("style");
+  style.textContent = [
+    ".vega-embed .error p {{",
+    "  color: firebrick;",
+    "  font-size: 14px;",
+    "}}",
+  ].join("\\n");
+
+  // element is a jQuery wrapped DOM element inside the output area
+  // see http://ipython.readthedocs.io/en/stable/api/generated/\
+  // IPython.display.html#IPython.display.Javascript.__init__
+  element[0].appendChild(target);
+  element[0].appendChild(style);
+
+  vega.render("#" + id, spec, type, opt, output_area);
+}}, function (err) {{
+  if (err.requireType !== "scripterror") {{
+    throw(err);
+  }}
+}});

vega/static/extension.js

@@ -0,0 +1,20 @@
+// This file contains the javascript that is run when the notebook is loaded.
+// It contains some requirejs configuration and the `load_ipython_extension`
+// which is required for any notebook extension.
+//
+// Some static assets may be required by the custom widget javascript. The base
+// url for the notebook is not known at build time and is therefore computed
+// dynamically.
+__webpack_public_path__ = document.querySelector('body').getAttribute('data-base-url') + 'nbextensions/jupyter-vega';
+
+
+// Configure requirejs
+if (window.require) {
+  window.require.config({
+    map: {
+      "*": {
+        "jupyter-vega": "nbextensions/jupyter-vega/index",
+      }
+    }
+  });
+}

vega/static/vega.js

@@ -5,7 +5,7 @@ const id = "{id}";
 
 const output_area = this;
 
-require(["nbextensions/jupyter-vega/index"], function(vega) {{
+require(["jupyter-vega"], function(vega) {{
   const target = document.createElement("div");
   target.id = id;
   target.className = "vega-embed";