Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the Vega editor with Vite works with linked Vega and Vega-Lite packages #1346

Closed
domoritz opened this issue Jun 29, 2023 · 4 comments · Fixed by #1420
Closed

Make sure the Vega editor with Vite works with linked Vega and Vega-Lite packages #1346

domoritz opened this issue Jun 29, 2023 · 4 comments · Fixed by #1420
Assignees
@domoritz
Labels
bug

Comments

@domoritz
Copy link
Member

domoritz commented Jun 29, 2023 •
edited
Loading

Developers, for now, roll back to a pre-vote version: 53b8515
@domoritz domoritz self-assigned this Jun 29, 2023
@sfc-gh-cheliu

This comment was marked as off-topic.

Sign in to view
This was referenced Sep 19, 2023
Closed
Closed
@sfc-gh-cheliu
Copy link

@domoritz I guess this is still yarn link issue, appreciate it if you could give some suggestions. Thanks.

@kanitw
Copy link
Member

kanitw commented Nov 14, 2023

Ok I thought something is wrong with my computer. lol

@domoritz
Copy link
Member Author

I think we are running into vitejs/vite#8619. I got it mostly working but you need to save your Vite config file right now. The plus is that you don't even need to rebuild or watch Vega-Lite anymore.

domoritz added a commit that referenced this issue Nov 26, 2023
@domoritz
Support some updating
a65e189 
#1346
@domoritz domoritz added the bug label Jan 6, 2024
@domoritz domoritz mentioned this issue Jan 6, 2024
Closed
@domoritz domoritz mentioned this issue May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoritz domoritz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use parcel instead of vite vega/editor
3 participants
@kanitw @domoritz @sfc-gh-cheliu