Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and add_selection() method #832

Merged
merged 2 commits into from
May 14, 2018
Merged

Add and add_selection() method #832

merged 2 commits into from
May 14, 2018

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented May 13, 2018

Fixes #810

ellisonbg
ellisonbg approved these changes May 13, 2018
View reviewed changes
Copy link
Collaborator

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jakevdp
Copy link
Collaborator Author

jakevdp commented May 14, 2018

Thanks Brian!

@jakevdp jakevdp merged commit b83982f into vega:master May 14, 2018
@jakevdp jakevdp deleted the add-selection branch May 14, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonbg ellisonbg ellisonbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakevdp @ellisonbg