Check field names #399
Merged
Check field names #399
+158
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
requested changes
Oct 6, 2017
| if field is not jst.undefined: | ||
| data_columns.add(field) | ||
| # Find columns in the visual encoding that are not in the data | ||
| missing_columns = encoded_columns - data_columns |
There was a problem hiding this comment.
We need to manually remove "*" from missing columns
|
Another thing this needs is to check data within compound charts. Unfortunately, in vega-lite 1.X, that behavior is not well-defined. I think it's better handled in 2.X. |
|
I'm not certain, but I think this change would cause a failure if you have a layered chart that contains a Chart object without its own data |
|
Do you think it is worth trying to get it working with the 1.x layered
chart API?
…On Fri, Oct 6, 2017 at 1:48 PM, Jake Vanderplas ***@***.***> wrote:
I'm not certain, but I think this change would cause a failure if you have
a layered chart that contains a Chart object without its own data
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#399 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0C6zqgPO7aRT-ZkdYqHW75dm4Po5ks5sppI3gaJpZM4PrUHY>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]
|
|
Hard to say... I worry we'd end up in a place where we raise an error on input that should work, because we're not looking in the right place for the column names. |
ellisonbg
force-pushed
the
check-field-names
branch
from
952654d
to
1563986
Compare
jakevdp
approved these changes
Oct 17, 2017
|
Looks good – thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
_validate_specmethod to theChartobject that is called during the last phase of_finalize(after shortcuts and expressions have been processed). It catches channels with missing fields and fields that are not in the dataset. It should ignore URL based datasets. Tests are included.My only concern is how this will function for facetted and layered charts. I fear it will have the same problems that PR #185 does. But it would be a huge usability improvement that would catch the most common sources of silent failures that Altair users see.
I won't merge this until we get a chance to discuss and review...
Fixes #388