Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve alt.binding signature/docstring issues #3671

Merged
merged 6 commits into from
Nov 3, 2024
Merged

fix: Resolve alt.binding signature/docstring issues #3671

merged 6 commits into from
Nov 3, 2024

Commits on Oct 24, 2024

  1. feat: Use BindInput for binding() instead of Binding 

    - `Binding` is not generic, it is a union of all bindings
- It has no doc or parameters
- `binding()` currently forces this function to be `BindInput` as `input` is a required argument
    @dangotbanned
    dangotbanned committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ef05e9e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Merge branch 'main' into binding-input

    @dangotbanned
    dangotbanned committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    57281fd View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. fix: Support input as positional again 

    - Discovered the backwards incompatibility during testing
- Manually spelling out the signature & copying the docs; was the only reliable method I found
    @dangotbanned
    dangotbanned committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b42cdb8 View commit details
    Browse the repository at this point in the history

  2. test: Adds test_binding 

    - Ensures new signature is fully backwards compatible
- Demonstrates (previously) inconsistent typing behavior that is now resolved
    @dangotbanned
    dangotbanned committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    0266b8d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into binding-input

    @dangotbanned
    dangotbanned authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b13070b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into binding-input

    @dangotbanned
    dangotbanned authored Nov 3, 2024
    Configuration menu
    Copy the full SHA
    4df3809 View commit details
    Browse the repository at this point in the history