Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Correct nested expr equivalence #3624

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

dangotbanned
Copy link
Member

Spotted while investigating #3616 (comment)

When I originally wrote this test, I didn't realise I was comparing:

GetAttrExpression(Parameter.name, "expr") == GetAttrExpression(Parameter.name, "expr")

The intention was to check the contents were the same.
But due to OperatorMixin.__eq__, the previous assertion would always return True.

Spotted while investigating #3616 (comment)

When I originally wrote this test, I didn't realise I was comparing:
```py
GetAttrExpression(Parameter.name, "expr") == GetAttrExpression(Parameter.name, "expr")
```

The intention was to compare the contents were the same.

Due to `OperatorMixin.__eq__`, the previous assertion would always return `True`.
@dangotbanned dangotbanned enabled auto-merge (squash) October 2, 2024 15:10
@dangotbanned dangotbanned merged commit 17968ea into main Oct 2, 2024
25 checks passed
@dangotbanned dangotbanned deleted the fix-when-test-assert-expr branch October 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant