Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support a wider range of iterables in SchemaBase.to_dict #3501

Merged
merged 27 commits into from
Aug 9, 2024
Merged

feat: Support a wider range of iterables in SchemaBase.to_dict #3501

merged 27 commits into from
Aug 9, 2024

Commits on Jul 24, 2024

  1. feat: Support a wider range of iterables in SchemaBase.to_dict

    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1ff970c View commit details
    Browse the repository at this point in the history

  2. test: Update validation errors to use non-iterable element type 

    Previously `list[set[str]]`
    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1f3dfd3 View commit details
    Browse the repository at this point in the history

  3. fix: Prevent to_dict method being called on pd.Series 

    AFAIK, this is the intended case for `Parameter | Expression` not for converting arbitrary objects
    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3275c5e View commit details
    Browse the repository at this point in the history

  4. test: Add tests for iterables and ranges

    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d37bacc View commit details
    Browse the repository at this point in the history

  5. fix(typing): Ignore type errors for tests

    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    84c599f View commit details
    Browse the repository at this point in the history

  6. refactor: Use narwhals.stable.v1 

    vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    438ddf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    04c292a View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7fe3929 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6552880 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c46333c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6840181 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    73c873c View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Aug 4, 2024
    Configuration menu
    Copy the full SHA
    4dbe986 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. test: Increase coverage in test_to_dict_iterables 

    The original test obscured the fact that this change applies anywhere a `Sequence` is annotated.
    @dangotbanned
    dangotbanned committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e15bbed View commit details
    Browse the repository at this point in the history

  2. docs: Add a doc for test_to_dict_iterables

    @dangotbanned
    dangotbanned committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    755670b View commit details
    Browse the repository at this point in the history

  3. revert: Change test_chart_validation_errors back to demonstrate fai… 

    …lures to @joelostblom

Reverting 1f3dfd3

vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    bc4f4aa View commit details
    Browse the repository at this point in the history

  4. docs: Update User Guide to use Sequence 

    vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7e57e34 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    009b040 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. test: Fix test_chart_validation_errors failure verbosity 

    vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f9feebc View commit details
    Browse the repository at this point in the history

  2. refactor: Move inspect.cleandoc inside of `test_chart_validation_er… 

    …rors`

All 18 cases use this, saves 30 lines
    @dangotbanned
    dangotbanned committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f335404 View commit details
    Browse the repository at this point in the history

  3. revert: Restore original fix to test_chart_validation_errors 

    vega#3501 (comment)
vega#3501 (comment)
vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bbe33d4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    877b8d8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into to-dict-from-arraylike

    @dangotbanned
    dangotbanned authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3c7e244 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. docs: Remove "ordered" descriptor from Sequence 

    Co-authored-by: Joel Ostblom <[email protected]>
    @dangotbanned @joelostblom
    dangotbanned and joelostblom authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e07b953 View commit details
    Browse the repository at this point in the history

  2. test: Remove missed inspect.cleandoc 

    vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    301e8f7 View commit details
    Browse the repository at this point in the history

  3. test: Only modify message, not input to test_chart_validation_errors 

    vega#3501 (comment)
    @dangotbanned
    dangotbanned committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8739239 View commit details
    Browse the repository at this point in the history

  4. style: fix oddly formatted test_multiple_field_strings_in_condition

    @dangotbanned
    dangotbanned committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1575e1e View commit details
    Browse the repository at this point in the history