fix: solve mypy errors which are due to same object names in core.py and channels.py #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exported from core.py so that altair.Color is correctly identified as coming from channels.py
binste
changed the title
|
Haha same here ;) Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3408. See this comment for a description of the issue). This PR adds
__all__tocore.pywhich includes all objects which were previously exported except forColorandTextwhich are names which are also defined inchannels.py. With this, mypy can correctly detect the type of the top-levelaltair.Colorandaltair.Textas coming fromchannels.pyand notcore.py.I've tested against the main branch that all objects are still exported except for some objects from
typingwhich are not needed anyway. On the top-level of Altair, you can also see that nothing changed as the auto-generated_all__inaltair/__init__.pydid not change. Hence, this is purely a fix for mypy and does not have any functional implications for users.