Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Parameter class directly in type hints instead of _Parameter protocol #3405

Closed
wants to merge 5 commits into from
Closed

refactor: Use Parameter class directly in type hints instead of _Parameter protocol #3405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5ff235
Remove _Parameter Protocol and instead solve circular imports with a …
binste Apr 14, 2024
95111ca
Refactor
binste Apr 14, 2024
ffd7f88
Merge branch 'main' into use_type_checking_blocks
binste May 24, 2024
847baf4
Minor stuff
binste May 24, 2024
4378d5a
Merge branch 'main' into use_type_checking_blocks
mattijn Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions altair/vegalite/v5/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ def _get_channels_mapping() -> TypingDict[TypingType[core.SchemaBase], str]:
class Parameter(_expr_core.OperatorMixin):
"""A Parameter object"""

# NOTE: If you change this class, make sure that the protocol in
# altair/vegalite/v5/schema/core.py is updated accordingly if needed.

_counter: int = 0

@classmethod
Expand Down
Loading