Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extend .interactive() with tooltip and legend #3394

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

feat: Extend .interactive() with tooltip and legend #3394

wants to merge 36 commits into from
+256 −14

Commits on Aug 11, 2024

  1. Add tooltip and legend to .interactive()

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    1e85a59 View commit details
    Browse the repository at this point in the history

  2. Avoid using configure to be compatible with layered specs

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    e76a3e2 View commit details
    Browse the repository at this point in the history

  3. Avoid calling to_dict() since validate=False is currently not sup… 

    …ported for channels
    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    7c127fd View commit details
    Browse the repository at this point in the history

  4. Detect encodings used in spec from possible legend encodings 

    There are many encodings that are never used in the legend which we do not need to include
    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    d20ecc8 View commit details
    Browse the repository at this point in the history

  5. Indicate which legend encodings are currently working

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    7fea185 View commit details
    Browse the repository at this point in the history

  6. Switch to using the react: false approach 

    This allows us to precompute the domain without access to the data in the python code. One current issue is that that domain is not sorted, which we will need to deal with in a follow up.
    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    343bb94 View commit details
    Browse the repository at this point in the history

  7. Format docstring as per ruff

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    0b5b688 View commit details
    Browse the repository at this point in the history

  8. Support only one legend encoding channel 

    Vega-Lite does not allow for more than one channel
when binding a parameter to the legend
    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    cbf51c4 View commit details
    Browse the repository at this point in the history

  9. Ruffify

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    29994be View commit details
    Browse the repository at this point in the history

  10. Note that name can be None

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    8d85e02 View commit details
    Browse the repository at this point in the history

  11. Ignore mypy type error for next built-in

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    f3a5a17 View commit details
    Browse the repository at this point in the history

  12. Add additional legend encoding channel and indicate types

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    f2305bd View commit details
    Browse the repository at this point in the history

  13. Use is_undefined instead of isinstance 

    Co-authored-by: Dan Redding <[email protected]>
    @joelostblom @dangotbanned
    joelostblom and dangotbanned committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    2981860 View commit details
    Browse the repository at this point in the history

  14. Simplify types 

    Co-authored-by: Dan Redding <[email protected]>
    @joelostblom @dangotbanned
    joelostblom and dangotbanned committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    32f900e View commit details
    Browse the repository at this point in the history

  15. Skip checking function complexity

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    cc3df47 View commit details
    Browse the repository at this point in the history

  16. Don't expect str type 

    Co-authored-by: Dan Redding <[email protected]>
    @joelostblom @dangotbanned
    joelostblom and dangotbanned authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    706f374 View commit details
    Browse the repository at this point in the history

  17. Adjust type to indicate that it is a list of channels

    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    3eb743e View commit details
    Browse the repository at this point in the history

  18. Indicate that there is only a subset of encodings allowed for the leg… 

    …end rather than all availabe ones
    @joelostblom
    joelostblom committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    4794028 View commit details
    Browse the repository at this point in the history

  19. refactor: Simplify typing, split up .interactive() for reuse

    @dangotbanned
    dangotbanned committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    a8001da View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Draft test suite

    @joelostblom
    joelostblom committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    49bd736 View commit details
    Browse the repository at this point in the history

  2. Do not try to iterate over encodings in the spec when there are none

    @joelostblom
    joelostblom committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    b125c19 View commit details
    Browse the repository at this point in the history

  3. Ensure that tooltips are added 

    Previously the tooltip would not be added
since mark was overwitten and no longer pointing to chart.mark
    @joelostblom
    joelostblom committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    01644a2 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into interactive_tooltip… 

    …_legend
    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    24b8aab View commit details
    Browse the repository at this point in the history

  5. test(typing): Add annotations

    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    708457c View commit details
    Browse the repository at this point in the history

  6. test: Adds all_chart_types, color_data fixtures

    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    51fd920 View commit details
    Browse the repository at this point in the history

  7. test: Add xfail(s) for unimplemented in `test_interactive_for_chart… 

    …_types`
    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    885767a View commit details
    Browse the repository at this point in the history

  8. test: Update test_interactive_with_no_encoding to use `all_chart_ty… 

    …pes`
    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    728d3cb View commit details
    Browse the repository at this point in the history

  9. test: Use color_data in `test_interactive_legend_made_interactive_f… 

    …or_appropriate_encodings_types`
    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    61281d7 View commit details
    Browse the repository at this point in the history

  10. test: Adds implementation for `test_interactive_legend_made_interacti… 

    …ve_for_legend_encodings`

The `KeyError` is for `Radius2` not having a `type` parameter.
    @dangotbanned
    dangotbanned committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    5204759 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Merge remote-tracking branch 'upstream/main' into interactive_tooltip… 

    …_legend
    @dangotbanned
    dangotbanned committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ab7dab4 View commit details
    Browse the repository at this point in the history

  2. test: Add repro for failing test 

    #3394 (comment)
    @dangotbanned
    dangotbanned committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c6dac9d View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Merge branch 'main' into interactive_tooltip_legend

    @joelostblom
    joelostblom authored Aug 25, 2024
    Configuration menu
    Copy the full SHA
    5f47fa0 View commit details
    Browse the repository at this point in the history

  2. test: Remove test case fixed by #3553

    @dangotbanned
    dangotbanned committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    bd7ccfb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into interactive_tooltip… 

    …_legend
    @dangotbanned
    dangotbanned committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    4b12df6 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge remote-tracking branch 'upstream/main' into interactive_tooltip… 

    …_legend
    @dangotbanned
    dangotbanned committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d9f8850 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge branch 'main' into interactive_tooltip_legend

    @dangotbanned
    dangotbanned authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    479fe27 View commit details
    Browse the repository at this point in the history